Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test to confirm observedAttributes behavior #2973

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

nolanlawson
Copy link
Collaborator

Details

Adds a karma test to confirm the behavior described in #2972.

Does this pull request introduce a breaking change?

  • ✅ No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • ✅ No, it does not introduce an observable change.

Copy link
Member

@jmsjtu jmsjtu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@nolanlawson nolanlawson merged commit 4f97aeb into master Aug 4, 2022
@nolanlawson nolanlawson deleted the nolan/observes branch August 4, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants