refactor: remove shadowSupportMode = 'any'
#3953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmsjtu
commented
Jan 18, 2024
| @@ -1,8 +1,6 @@ | |||
| import { LightningElement, api } from 'lwc'; | |||
|
|
|||
| export default class extends LightningElement { | |||
| static shadowSupportMode = 'any'; | |||
There was a problem hiding this comment.
@nolanlawson could you take a look at this change?
Wanted to make sure this test still behaves as intended.
There was a problem hiding this comment.
We had a hard time understanding this test! We decided to remove this in the end, because we realized that it was basically a NOOP due to the feature flag not being enabled.
nolanlawson
approved these changes
Jan 25, 2024
ekashida
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR removes the
shadowSupportMode = 'any'option.Does this pull request introduce a breaking change?
shadowSupportMode = 'any'was gated behind a feature flag and should not break existing customers.Does this pull request introduce an observable change?
GUS work item
W-14832125