Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: warn on shadowSupportMode 'any' #3972

Merged
merged 11 commits into from
Feb 6, 2024
Merged

chore: warn on shadowSupportMode 'any' #3972

merged 11 commits into from
Feb 6, 2024

Conversation

ekashida
Copy link
Member

@ekashida ekashida commented Feb 5, 2024

Details

This avoids making the removal of shadowSupportMode="any" a breaking change.

Does this pull request introduce a breaking change?

  • ✅ No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • ✅ No, it does not introduce an observable change.

GUS work item

W-14974451

@ekashida ekashida requested a review from a team as a code owner February 5, 2024 22:26
Copy link
Collaborator

@nolanlawson nolanlawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, otherwise LGTM

@ekashida ekashida merged commit 1432a38 into master Feb 6, 2024
9 checks passed
@ekashida ekashida deleted the ekashida/warn-any branch February 6, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants