fix(engine-dom): support LWC v5 compiler slot format #3973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😞 |
jye-sf
reviewed
Feb 6, 2024
| @@ -5,155 +5,164 @@ import Component from 'x/component'; | |||
| import ComponentWithProp from 'x/componentWithProp'; | |||
| import ComponentWithTemplateAndStylesheet from 'x/componentWithTemplateAndStylesheet'; | |||
|
|
|||
| describe('compiler version mismatch', () => { | |||
There was a problem hiding this comment.
Github UI totally mangled this file's diffs 😞
| const { rollup } = require('rollup'); | ||
| const lwcRollupPlugin = require('@lwc/rollup-plugin'); |
There was a problem hiding this comment.
sanity check: are none of the slot-related tests in @lwc/integration-tests affected by this slot format change? That project's build.js has its own separate entry point.
There was a problem hiding this comment.
It's possible that @lwc/integration-tests is affected, but I'm hoping the Karma tests are sufficient. The @lwc/integration-tests are not terribly well-maintained at this point.
jye-sf
reviewed
Feb 6, 2024
jye-sf
approved these changes
Feb 6, 2024
This was referenced Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
In #3883 we changed the format of the compiled components to use the
slotAssignmentkey rather thanattrs.slot.Unfortunately this breaks anyone who uses the LWC v5 compiler in combination with the v6 engine.
Version mismatches between the compiler and the engine have never been supported, but as a temporary measure, this PR proposes that we support v5-compiler-plus-v6-engine.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-14974789