Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): fix constructor with args #5094

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix(ssr): fix constructor with args #5094

merged 1 commit into from
Jan 6, 2025

Conversation

nolanlawson
Copy link
Collaborator

@nolanlawson nolanlawson commented Jan 3, 2025

Details

Fixes #5080

Ended up being a pretty straightforward fix.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

@nolanlawson nolanlawson requested a review from a team as a code owner January 3, 2025 23:23
@nolanlawson nolanlawson merged commit e4b3c46 into master Jan 6, 2025
10 checks passed
@nolanlawson nolanlawson deleted the nolan/super-args branch January 6, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SSR] Superclasses cannot have constructor arguments
2 participants