perf(ssr): remove filterProperties
#5101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Jan 7, 2025
| ) { | ||
| (this as any)[propName] = props[propName]; | ||
| } | ||
| } |
There was a problem hiding this comment.
Most of this is copypasta'd from filterProperties. Note this.#props doesn't really matter because we only ever check the class on it.
wjhsf
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This is another small perf improvement, on the order of 6-11%. The optimization here is to avoid creating an additional object via
filterPropertiesand instead to do the filtering directly when setting properties on the component.There are probably more optimizations that can be done here, but starting with this small change.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?