chore(@lwc/compiler): fix type error in transform-html.spec.ts #5158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This error seems to have been introduced in #4825 , which made namespace and name required in TransformOptions:
lwc/packages/@lwc/compiler/src/options.ts
Lines 96 to 100 in 423240c
Tests aren't really type-checked until opened in an editor, so it slipped by. In #4458 similar type errors were fixed, but by changing the types instead of the tests.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item