Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(@lwc/compiler): fix type error in transform-html.spec.ts #5158

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

cardoso
Copy link
Contributor

@cardoso cardoso commented Jan 22, 2025

Details

This error seems to have been introduced in #4825 , which made namespace and name required in TransformOptions:

export interface TransformOptions {
/** The name of the component. For example, the name in `<my-component>` is `"component"`. */
name: string;
/** The namespace of the component. For example, the namespace in `<my-component>` is `"my"`. */
namespace: string;

Tests aren't really type-checked until opened in an editor, so it slipped by. In #4458 similar type errors were fixed, but by changing the types instead of the tests.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

GUS work item

@cardoso cardoso requested a review from a team as a code owner January 22, 2025 15:52
@wjhsf
Copy link
Contributor

wjhsf commented Jan 22, 2025

/nucleus test

@wjhsf wjhsf merged commit a88ebeb into salesforce:master Jan 22, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants