Stream Mapping mode #86
Conversation
|
Thanks for the contribution! Before we can merge this, we need @notdanhan to sign the Salesforce Inc. Contributor License Agreement. |
|
I signed the CLA and the bot crashed? |
| @@ -1,177 +1,179 @@ | |||
| /* | |||
There was a problem hiding this comment.
the clang_format file triggered this noise
| std::string GetFlushRate() const { return GetParameter("--flushRate"); }; | ||
| std::string GetNoColor() const { return GetParameter("--noColor"); }; | ||
| std::string GetNoMerge() const { return GetParameter("--noMerge"); }; | ||
| std::string GetStreamMappings() const { return GetParameter("--streamMappings"); }; |
| PRINT("Excluded paths: " << exclusions.size()); | ||
| if (maxChanges > -1) | ||
| { | ||
| ERR("MaxChanges and StreamMappings cannot be used together! exiting."); |
There was a problem hiding this comment.
Is there a specific reason for this? If this is enabled, you wouldn't be able to clone the depot in batches and instead it will always need to be done in a single shot. This could be a problem, but I guess we don't have anyone asking for batches right now except for Sourcegraph
There was a problem hiding this comment.
I suppose it'll probably work as-is with the max changes stuff since they're sorted in together, I'll have to add extra logic for pruning the vector of ChangeLists at the end, shouldn't take too long to do.
| PRINT("Path: " << mapped.stream2 << " has " << temp.size() << " changes!"); | ||
| changes.insert(changes.end(), std::make_move_iterator(temp.begin()), std::make_move_iterator(temp.end())); | ||
| } | ||
| std::sort(changes.begin(), changes.end()); |
There was a problem hiding this comment.
This is a genius way of sorting CLs coming from different streams. Amazing!
| @@ -287,7 +373,7 @@ int Main(int argc, char** argv) | |||
| cl.WaitForDownload(); | |||
|
|
|||
| std::string fullName = cl.user; | |||
| std::string email = "deleted@user"; | |||
| std::string email = "deleted@user.com"; | |||
There was a problem hiding this comment.
I don't think we should make any changes to this string. This is very much legacy at this point which we can't break for people already using this string to detect deleted users in the generated Git history.
this allows you to use Stream view mappings as per the request of
#83
Built and runs on WSL and OpenSuse Tumbleweed