chore: update typescript and typescript/eslint plugin to v4 #37

mohanraj-r · 2020-09-08T22:46:58Z

Fixes #27

Chores 🧹

Update to next major release of TypeScript 4.0 bringing increased build speeds and other improvements
Update to next major release of typescript-eslint/typescript-eslint containing several breaking changes
Update to patch release of axe-core 4.0.2
Update other dev deps to minor/patch releases

Refactor ♻

Fix code to take care of the new errors from the upgraded versions
- Silencing rules only as last resort esp. in non application code (test, config etc)
Fix how default options are processed for formatter
Fix chained npm cmds to depend on previous exit code
Reuse common typescript config for eslint

Post merge

Merge into feat: add option to target specific elements from WDIO APIs #35 - updating changelog, release notes, versions etc

fixes salesforce#27

…-eslint, typescript temp fix - errors need to be fixed and check enabled

…t, typescript

reduces errors due to upgrade from 80+ to 60+

…cking

…t plugin

… type errors clean install yarn lock file

https://github.com/dequelabs/axe-core/releases/tag/v4.0.2

from https://github.com/salesforce/oss-template

mohanraj-r · 2020-09-14T23:31:53Z

@trevor-bliss Can you please give this a glance

trevor-bliss · 2020-09-15T19:42:34Z

packages/wdio/__tests__/wdio.test.ts

@@ -11,6 +11,8 @@ import { htmlFileWithA11yIssues, htmlFileWithNoA11yIssues } from '@sa11y/test-ut
 import { A11yError } from '@sa11y/format';
 import { axeRuntimeExceptionMsgPrefix } from '@sa11y/common';

+// TODO (chore): Raise issue with WebdriverIO - 'sync' missing 'default' in ts def
+// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-var-requires
 const sync = require('@wdio/sync').default;


What about this?

import sync from '@wdio/sync';

I tried that. It results in the tests being skipped with wdio runner reporting that 1 suite passed without running any tests weirdly and also the following error.

TS1259: Module '"@wdio/sync"' can only be default-imported using the 'esModuleInterop' flag webdriverio.d.ts(46, 5): This module is declared with using 'export =', and can only be used with a default import when using the 'esModuleInterop' flag.

I do have the "esModuleInterop": true, in tsconfig.

Also tried import sync = require('@wdio/sync'); as suggested in the TypeScript: Handbook - Modules

When exporting a module using export =, TypeScript-specific import module = require("module") must be used to import the module.

Even though typescript is happy with that, the tests continue to be skipped.

Think this could be related to the fact that ts-node is used by wdio.conf.js and it might be interpreting the tsconfig differently? I tried reusing babel (which is used by jest) instead of ts-node but couldn't get it working (webdriverio/webdriverio#5588)

Please let me know if you have any suggestions.

Added a TODO to reflect this for now

Hm weird... Yeah that's fine.

trevor-bliss

Suggestion for importing the sync API from wdio, rest looks good.

mohanraj-r

Thanks for the review @trevor-bliss !

mohanraj-r · 2020-09-15T20:42:56Z

packages/wdio/__tests__/wdio.test.ts

@@ -11,6 +11,8 @@ import { htmlFileWithA11yIssues, htmlFileWithNoA11yIssues } from '@sa11y/test-ut
 import { A11yError } from '@sa11y/format';
 import { axeRuntimeExceptionMsgPrefix } from '@sa11y/common';

+// TODO (chore): Raise issue with WebdriverIO - 'sync' missing 'default' in ts def
+// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-var-requires
 const sync = require('@wdio/sync').default;


I tried that. It results in the tests being skipped with wdio runner reporting that 1 suite passed without running any tests weirdly and also the following error.

TS1259: Module '"@wdio/sync"' can only be default-imported using the 'esModuleInterop' flag webdriverio.d.ts(46, 5): This module is declared with using 'export =', and can only be used with a default import when using the 'esModuleInterop' flag.

I do have the "esModuleInterop": true, in tsconfig.

Also tried import sync = require('@wdio/sync'); as suggested in the TypeScript: Handbook - Modules

When exporting a module using export =, TypeScript-specific import module = require("module") must be used to import the module.

Even though typescript is happy with that, the tests continue to be skipped.

Think this could be related to the fact that ts-node is used by wdio.conf.js and it might be interpreting the tsconfig differently? I tried reusing babel (which is used by jest) instead of ts-node but couldn't get it working (webdriverio/webdriverio#5588)

Please let me know if you have any suggestions.

trevor-bliss · 2020-09-16T06:45:54Z

packages/wdio/__tests__/wdio.test.ts

@@ -11,6 +11,8 @@ import { htmlFileWithA11yIssues, htmlFileWithNoA11yIssues } from '@sa11y/test-ut
 import { A11yError } from '@sa11y/format';
 import { axeRuntimeExceptionMsgPrefix } from '@sa11y/common';

+// TODO (chore): Raise issue with WebdriverIO - 'sync' missing 'default' in ts def
+// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-var-requires
 const sync = require('@wdio/sync').default;


Hm weird... Yeah that's fine.

after merging upgrade to typescript 4 (salesforce#37) into master

Mohan Raj Rajamanickam and others added 13 commits September 1, 2020 10:58

build: update typescript to v4 and eslint pkgs

b2ef156

fixes salesforce#27

test(eslint): disable strict type checking after upgrading typescript…

df9d249

…-eslint, typescript temp fix - errors need to be fixed and check enabled

refactor: fix to take care of eslint errors with new version of eslin…

29e3dda

…t, typescript

refactor(eslint): reuse ts common config in ts config for eslint

700b977

reduces errors due to upgrade from 80+ to 60+

test(eslint): enable typescript-eslint/recommended-requiring-type-che…

3c4ddd0

…cking

test(eslint): fix lint issues after upgrading to new typescript eslin…

5f5b746

…t plugin

refactor(format): fix how default options are processed for formatter

6bdedfd

test(wdio): fix wdio tests broken when fixing lint warnings

c2525ef

build: fix chained npm scripts to depend on previous exit code

db918ad

chore: update dev dependencies

4babe54

test(lint): add typescript compile only step to lint all cmd to catch…

65076d0

… type errors clean install yarn lock file

docs: remove obsolete todo about new lint errors

07527bc

chore: update dev deps

f6269af

mohanraj-r requested a review from a team as a code owner September 8, 2020 22:46

mohanraj-r self-assigned this Sep 8, 2020

mohanraj-r requested a review from trevor-bliss September 8, 2020 22:47

mohanraj-r added 3 commits September 14, 2020 16:16

chore: update dev deps; axe-core to 4.0.2

e19a162

test(format): update output to reflect changes in axe-core 4.0.2

ead4ae7

https://github.com/dequelabs/axe-core/releases/tag/v4.0.2

docs: add security readme file for the project

3f5905c

from https://github.com/salesforce/oss-template

mohanraj-r requested a review from cordeliadillon as a code owner September 14, 2020 23:25

chore: remove cruft from yarn lock with a clean install

9c3e73c

trevor-bliss reviewed Sep 15, 2020

View reviewed changes

trevor-bliss previously approved these changes Sep 15, 2020

View reviewed changes

mohanraj-r commented Sep 15, 2020

View reviewed changes

chore: update dev deps (prettier, types/node)

f8bfda8

mohanraj-r dismissed trevor-bliss’s stale review via 8713a0d September 16, 2020 03:08

test(wdio): add TODO clarifying using 'require' instead of 'import'

8713a0d

trevor-bliss approved these changes Sep 16, 2020

View reviewed changes

mohanraj-r merged commit bc3b2c8 into salesforce:master Sep 16, 2020

mohanraj-r deleted the update_typescript_4 branch September 16, 2020 19:51

mohanraj-r restored the update_typescript_4 branch September 16, 2020 19:52

mohanraj-r deleted the update_typescript_4 branch September 16, 2020 19:54

mohanraj-r added a commit to mohanraj-r/sa11y that referenced this pull request Sep 17, 2020

chore: merge branch 'master' into feat_wdio_selected_elements

e3d97d6

after merging upgrade to typescript 4 (salesforce#37) into master

mohanraj-r added a commit to mohanraj-r/sa11y that referenced this pull request Sep 17, 2020

docs: update changelog to reflect merge of salesforce#37

cb21d63

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update typescript and typescript/eslint plugin to v4 #37

chore: update typescript and typescript/eslint plugin to v4 #37

mohanraj-r commented Sep 8, 2020 •

edited

Loading

mohanraj-r commented Sep 14, 2020

trevor-bliss Sep 15, 2020

mohanraj-r Sep 15, 2020

mohanraj-r Sep 16, 2020

trevor-bliss Sep 16, 2020

trevor-bliss left a comment

mohanraj-r left a comment

mohanraj-r Sep 15, 2020

trevor-bliss Sep 16, 2020

chore: update typescript and typescript/eslint plugin to v4 #37

chore: update typescript and typescript/eslint plugin to v4 #37

Conversation

mohanraj-r commented Sep 8, 2020 • edited Loading

Chores 🧹

Refactor ♻

Post merge

mohanraj-r commented Sep 14, 2020

trevor-bliss Sep 15, 2020

Choose a reason for hiding this comment

mohanraj-r Sep 15, 2020

Choose a reason for hiding this comment

mohanraj-r Sep 16, 2020

Choose a reason for hiding this comment

trevor-bliss Sep 16, 2020

Choose a reason for hiding this comment

trevor-bliss left a comment

Choose a reason for hiding this comment

mohanraj-r left a comment

Choose a reason for hiding this comment

mohanraj-r Sep 15, 2020

Choose a reason for hiding this comment

trevor-bliss Sep 16, 2020

Choose a reason for hiding this comment

mohanraj-r commented Sep 8, 2020 •

edited

Loading