Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using arguments #316

Merged
merged 11 commits into from
Nov 3, 2023
Merged

Avoid using arguments #316

merged 11 commits into from
Nov 3, 2023

Commits on Oct 26, 2023

  1. Ignore max-lines where appropriate.

    @wjhsf
    wjhsf committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    2402513 View commit details
    Browse the repository at this point in the history

  2. Change callback error signature to null instead of undefined.

    @wjhsf
    wjhsf committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    421b195 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary helper.

    @wjhsf
    wjhsf committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f2df0bb View commit details
    Browse the repository at this point in the history

  4. Split error callback and success callback for better type narrowing.

    @wjhsf
    wjhsf committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    ca0ec26 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Be more strict about resolving/rejecting values.

    @wjhsf
    wjhsf committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    d1b7446 View commit details
    Browse the repository at this point in the history

  2. Change promiseCallback to only accept a callback, not arguments.

    @wjhsf
    wjhsf committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    1df12e9 View commit details
    Browse the repository at this point in the history

  3. Hide annoying warnings that pop up in IDE.

    @wjhsf
    wjhsf committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    c216409 View commit details
    Browse the repository at this point in the history

  4. Handle different function signatures for callback argument.

    @wjhsf
    wjhsf committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    0fec493 View commit details
    Browse the repository at this point in the history

  5. Use more normal callback definition.

    @wjhsf
    wjhsf committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    a7a84f3 View commit details
    Browse the repository at this point in the history

  6. Modern syntax!

    @wjhsf
    wjhsf committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    7a24c79 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Revert "Remove unnecessary helper." Turns out it's necessary. 

    This reverts commit f2df0bb.
    @wjhsf
    wjhsf committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    5220bf6 View commit details
    Browse the repository at this point in the history