Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade typescript-eslint to 8.0.1 #440

Merged
merged 2 commits into from
Sep 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export default tseslint.config(
'@typescript-eslint/explicit-function-return-type': 'off',
'@typescript-eslint/no-var-requires': 'off',
'@typescript-eslint/no-unused-vars': 'off',
'@typescript-eslint/no-require-imports': 'off',
},
},
)
1 change: 1 addition & 0 deletions lib/cookie/cookie.ts
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ function fromJSON(str: unknown): Cookie | undefined {
if (typeof str === 'string') {
try {
obj = JSON.parse(str)
// eslint-disable-next-line @typescript-eslint/no-unused-vars
} catch (e) {
return undefined
}
Expand Down
3 changes: 2 additions & 1 deletion lib/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,9 @@ export function createPromiseCallback<T>(cb?: Callback<T>): PromiseCallback<T> {
try {
// If `err` is null, we know `result` must be `T`
// The assertion isn't *strictly* correct, as `T` could be nullish, but, ehh, good enough...
if (err) reject(err)
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
err ? reject(err) : resolve(result!)
else resolve(result!)
} catch (e) {
reject(e instanceof Error ? e : new Error())
}
Expand Down
278 changes: 136 additions & 142 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@
"ts-jest": "^29.2.2",
"ts-node": "^10.9.2",
"typescript": "5.5.3",
"typescript-eslint": "^7.16.1",
"typescript-eslint": "^8.0.1",
"vows": "^0.8.3"
},
"dependencies": {
Expand Down