Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(debug): set default log level #1246

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix(debug): set default log level #1246

merged 1 commit into from
Oct 27, 2023

Conversation

cristiand391
Copy link
Member

@cristiand391 cristiand391 commented Oct 26, 2023

What does this PR do?

makes --dev-debug to set SF_LOG_LEVEL=trace if it's not set.

before:

to get debug logs from oclif and logging output we need to set --dev-debug and SF_LOG_LEVEL env var

after:

only --dev-debug is required. The default log level is trace so that all logger output is included.

EDIT
this is already merged, but after this change you can't disable logging output when using --dev-debug.
Set DEBUG=* instead of --dev-debug if you only want to get debug output (looking for oclif-specific stuff)

What issues does this PR fix or reference?

@W-14375066@

@cristiand391 cristiand391 added the bug Something isn't working label Oct 26, 2023
@git2gus
Copy link

git2gus bot commented Oct 26, 2023

This issue has been linked to a new work item: W-14375066

@iowillhoit
Copy link
Contributor

QA NOTES

  • 🟢 Seeing trace logs with --dev-debug
  • 🟢 You can override it if you want SF_LOG_LEVEL=info bin/run.js org list --dev-debug
    • No trace logs shown

Looks good!

@iowillhoit iowillhoit merged commit 06fbb7f into main Oct 27, 2023
29 of 31 checks passed
@iowillhoit iowillhoit deleted the cd/debug-set-log-level branch October 27, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants