Skip to content

Commit

Permalink
fix: add missing flag aliases 'setdefaultdevhubusername'
Browse files Browse the repository at this point in the history
  • Loading branch information
peternhale committed Feb 21, 2023
1 parent 7201e6c commit a779339
Show file tree
Hide file tree
Showing 6 changed files with 366 additions and 398 deletions.
2 changes: 1 addition & 1 deletion src/commands/auth/accesstoken/store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export default class Store extends AuthBaseCommand<AuthFields> {
summary: commonMessages.getMessage('setDefaultDevHub'),
default: false,
deprecateAliases: true,
aliases: ['setdefaultdevhub'],
aliases: ['setdefaultdevhub', 'setdefaultdevhubusername'],
}),
'set-default': Flags.boolean({
char: 's',
Expand Down
6 changes: 3 additions & 3 deletions src/commands/auth/device/login.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export default class Login extends AuthBaseCommand<DeviceLoginResult> {
char: 'd',
summary: commonMessages.getMessage('setDefaultDevHub'),
deprecateAliases: true,
aliases: ['setdefaultdevhub'],
aliases: ['setdefaultdevhub', 'setdefaultdevhubusername'],
}),
'set-default': Flags.boolean({
char: 's',
Expand Down Expand Up @@ -72,10 +72,10 @@ export default class Login extends AuthBaseCommand<DeviceLoginResult> {

const oauthConfig: OAuth2Config = {
loginUrl: await Common.resolveLoginUrl(get(flags.instanceurl, 'href', null) as Optional<string>),
clientId: flags.clientid as string,
clientId: flags['client-id'] as string,
};

if (flags.clientid) {
if (flags['client-id']) {
oauthConfig.clientSecret = await this.askForClientSecret(flags['disable-masking']);
}

Expand Down
2 changes: 1 addition & 1 deletion src/commands/auth/jwt/grant.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export default class Grant extends AuthBaseCommand<AuthFields> {
char: 'd',
summary: commonMessages.getMessage('setDefaultDevHub'),
deprecateAliases: true,
aliases: ['setdefaultdevhub'],
aliases: ['setdefaultdevhub', 'setdefaultdevhubusername'],
}),
'set-default': Flags.boolean({
char: 's',
Expand Down
2 changes: 1 addition & 1 deletion src/commands/auth/sfdxurl/store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export default class Store extends AuthBaseCommand<AuthFields> {
char: 'd',
summary: commonMessages.getMessage('setDefaultDevHub'),
deprecateAliases: true,
aliases: ['setdefaultdevhub'],
aliases: ['setdefaultdevhub', 'setdefaultdevhubusername'],
}),
'set-default': Flags.boolean({
char: 's',
Expand Down
2 changes: 1 addition & 1 deletion src/commands/auth/web/login.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export default class Login extends AuthBaseCommand<AuthFields> {
char: 'd',
summary: commonMessages.getMessage('setDefaultDevHub'),
deprecateAliases: true,
aliases: ['setdefaultdevhubusername'],
aliases: ['setdefaultdevhub', 'setdefaultdevhubusername'],
}),
'set-default': Flags.boolean({
char: 's',
Expand Down
Loading

0 comments on commit a779339

Please sign in to comment.