-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support targeting browser in login command #537
Conversation
Thanks for the contribution! Before we can merge this, we need @aemounib to sign the Salesforce.com Contributor License Agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aemounib 👋🏼 , I left some minor suggestions but this looks great!
Thanks for the review, the suggestions have been implemented. |
QA✔️ Running ❌ If Firefox isn't installed and you run |
@RodEsp I tried running I'm ok with fixing this in a a separate PR since we will need to do it on plugin-org too and should work on all platforms. 👍🏼 |
Thanks for the contribution @aemounib! |
Btw, I created this issue, forcedotcom/cli#1830, to track the failed QA and marked it with the |
@RodEsp For sure. I will give it a shot, thanks. |
What does this PR do?
Add support for targeting browser in login command
What issues does this PR fix or reference?
forcedotcom/cli#1465