Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump to new major version of the open lib #968

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Mar 12, 2024

What does this PR do?

Bumps the open library to the new major version, v10.1.0 so that Windows users can define the shell to use for the command.

What issues does this PR fix or reference?

@W-15235605@
spawn EPERM error on Windows if user does not have powershell access

@cristiand391
Copy link
Member

tested on win machine with access to powershell.

sf org login web still opens browser ($env:SYSTEMROOT is set).
tried unsetting $env:SYSTEMROOT to make it use $env:windir but that broke spawning the local server.

both $env:SYSTEMROOT and $env:windir have the same value so they should work in any case.

@cristiand391 cristiand391 merged commit c6e6d67 into main Mar 12, 2024
12 checks passed
@cristiand391 cristiand391 deleted the sh/bump-open-lib branch March 12, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants