Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: @oclif/multi-stage-output #1120

Merged
merged 45 commits into from
Aug 20, 2024
Merged

feat: @oclif/multi-stage-output #1120

merged 45 commits into from
Aug 20, 2024

Conversation

mdonnalley
Copy link
Contributor

@mdonnalley mdonnalley commented Jun 27, 2024 •
edited
Loading

What does this PR do?

Use new @oclif/multi-stage-output for org create scratch and org resume scratch

What issues does this PR fix or reference?

@W-16441894@

@mdonnalley mdonnalley marked this pull request as draft June 27, 2024 19:33
mdonnalley and others added 25 commits June 27, 2024 13:35
@mdonnalley
Merge branch 'main' into mdonnalley/ink
b62f6ab
@svc-cli-bot
chore(release): 4.3.1-dev.0 [skip ci]
da220d5
@mdonnalley
fix: import messages dir
8a8e9c9
@svc-cli-bot
chore(release): 4.3.1-dev.1 [skip ci]
74ae4a9
@mdonnalley
fix: async components
f20f8f7
@mdonnalley
chore: try different methods
48e20f6
@mdonnalley
chore: add comment
a627e04
@mdonnalley
feat: dry up code and improve ux
4f992b7
@mdonnalley
feat: dry up code and improve ux
5c04dc8
@mdonnalley
chore: clean up
956e787
@mdonnalley
chore: clean up
408e0dd
@mdonnalley
feat: use ink for resume scratch
2d0cdc5
@mdonnalley
fix: dont render when json
9fff633
@mdonnalley
chore: more clean up
26fff88
@mdonnalley
chore: more clean up
b127e9e
@mdonnalley
chore: fine tune design
dd3de51
@mdonnalley
Merge branch 'main' into mdonnalley/ink
3fa4326
@svc-cli-bot
chore(release): 4.3.6-dev.0 [skip ci]
c33603f
@mdonnalley
chore: attempt to make multi stage framework
76d39f3
@mdonnalley
chore: getting closer
75b9ffd
@svc-cli-bot
chore(release): 4.3.6-dev.1 [skip ci]
74d86c5
@mdonnalley
chore: various improvements
f0af192
@svc-cli-bot
chore(release): 4.3.6-dev.2 [skip ci]
4a6f212
@mdonnalley
feat: ci design
d2df143
@mdonnalley
feat: lots of improvements
164fe45
@mdonnalley mdonnalley changed the title feat: use ink feat: @oclif/multi-stage-output Aug 8, 2024
@mdonnalley mdonnalley marked this pull request as ready for review August 16, 2024 17:19
@mdonnalley mdonnalley requested a review from a team as a code owner August 16, 2024 17:19
@WillieRuemmele
Copy link
Contributor

WillieRuemmele commented Aug 20, 2024 •
edited
Loading

QA Notes

✅ : looks good
image

✅ : warnings at end
✅ : --async
image
✅ : org resume scratch
image
✅ : errors displayed nicely
✅ : able to re-attach to org and finish auth/settings/creation
image
✅ : no --alias => no alias in output
✅ : no change to --json

✅ : can create sandbox - https://github.com/salesforcecli/plugin-org/actions/runs/10476681053/job/29016117698

@WillieRuemmele WillieRuemmele merged commit bfc34ef into main Aug 20, 2024
16 of 18 checks passed
@WillieRuemmele WillieRuemmele deleted the mdonnalley/ink branch August 20, 2024 20:14
mdonnalley added a commit that referenced this pull request Aug 26, 2024
@mdonnalley
Revert "Merge pull request #1120 from salesforcecli/mdonnalley/ink"
2d07192 
This reverts commit bfc34ef, reversing
changes made to 3499c53.
mdonnalley added a commit that referenced this pull request Aug 26, 2024
@mdonnalley
fix: revert MSO changes (#1192)
6d33c07 
* Revert "fix: bump multi-stage-output"

This reverts commit 36ed590.

* Revert "Merge pull request #1120 from salesforcecli/mdonnalley/ink"

This reverts commit bfc34ef, reversing
changes made to 3499c53.
mdonnalley pushed a commit that referenced this pull request Sep 4, 2024
@WillieRuemmele @mdonnalley
Merge pull request #1120 from salesforcecli/mdonnalley/ink
c4ddf5a 
feat: @oclif/multi-stage-output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillieRuemmele WillieRuemmele WillieRuemmele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdonnalley @WillieRuemmele @svc-cli-bot