fix: check for both sf and sfdx env vars #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -115,7 +117,8 @@ export class OrgOpenCommand extends SfCommand<OrgOpenOutput> { | |||
| if (err instanceof Error) { | |||
| if (err.message.includes('timeout')) { | |||
| const domain = `https://${/https?:\/\/([^.]*)/.exec(url)?.[1]}.lightning.force.com`; | |||
| const timeout = new Duration(new Env().getNumber('SFDX_DOMAIN_RETRY', 240), Duration.Unit.SECONDS); | |||
| const domainRetryTimeout = env.getNumber('SF_DOMAIN_RETRY') ?? env.getNumber('SFDX_DOMAIN_RETRY', 240); | |||
There was a problem hiding this comment.
should this be the same ||?
There was a problem hiding this comment.
No because env.getNumber() does not have a default value (like getBoolean() does) so if the env var is not set it returns undefined.
WillieRuemmele
approved these changes
Nov 6, 2023
QA Notes✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Check for both
SF_CONTAINER_MODEandSFDX_CONTAINER_MODECheck for both
SF_DOMAIN_RETRYandSFDX_DOMAIN_RETRYWhat issues does this PR fix or reference?
@W-14437987@
#2554