Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow sandbox name and license-type overrides #991

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Mar 18, 2024

What does this PR do?

Allows the sandbox name and license type to be overridden with flags while also using a definition file per the discussion here: forcedotcom/cli#2511 (reply in thread)

What issues does this PR fix or reference?

@W-15141701@

Copy link
Contributor

@mdonnalley mdonnalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one non-blocking comment

test/nut/sandboxCreate.nut.ts Outdated Show resolved Hide resolved
@mdonnalley
Copy link
Contributor

QA

Setup: checkout, yarn build, sf plugins link

sf org create sandbox --definition-file config/dev-sandbox-def.json --name mysandbox
🟢 Created sandbox with definition file and respected flag-provided name

@mdonnalley mdonnalley merged commit 60a001d into main Mar 18, 2024
12 checks passed
@mdonnalley mdonnalley deleted the sh/sandbox-name-override branch March 18, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants