fix: make command output clearer for un-implemented commands

Throw an error for all un-implemented beta commands.
salesforcecli · Aug 25, 2022 · 65cab44 · 65cab44
1 parent 2b3253f
commit 65cab44
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 15 deletions.
diff --git a/src/commands/force/package/beta/convert.ts b/src/commands/force/package/beta/convert.ts
@@ -52,8 +52,8 @@ export class PackageConvert extends SfdxCommand {
     }),
   };
 
+  // eslint-disable-next-line @typescript-eslint/require-await
   public async run(): Promise<unknown> {
-    process.exitCode = 1;
-    return Promise.resolve('Not yet implemented');
+    throw new Error('Beta command not yet implemented');
   }
 }
diff --git a/src/commands/force/package/beta/uninstall/report.ts b/src/commands/force/package/beta/uninstall/report.ts
@@ -25,8 +25,8 @@ export class PackageUninstallReportCommand extends SfdxCommand {
     }),
   };
 
+  // eslint-disable-next-line @typescript-eslint/require-await
   public async run(): Promise<unknown> {
-    process.exitCode = 1;
-    return Promise.resolve('Not yet implemented');
+    throw new Error('Beta command not yet implemented');
   }
 }
diff --git a/src/commands/force/package/beta/update.ts b/src/commands/force/package/beta/update.ts
@@ -42,8 +42,8 @@ export class PackageUpdateCommand extends SfdxCommand {
     }),
   };
 
+  // eslint-disable-next-line @typescript-eslint/require-await
   public async run(): Promise<unknown> {
-    process.exitCode = 1;
-    return Promise.resolve('Not yet implemented');
+    throw new Error('Beta command not yet implemented');
   }
 }
diff --git a/src/commands/force/package/beta/version/create/list.ts b/src/commands/force/package/beta/version/create/list.ts
@@ -31,8 +31,8 @@ export class PackageVersionCreateListCommand extends SfdxCommand {
     }),
   };
 
-  public async run(): Promise<unknown> {
-    process.exitCode = 1;
-    return Promise.resolve('Not yet implemented');
+  // eslint-disable-next-line @typescript-eslint/require-await
+  public async run(): Promise<never> {
+    throw new Error('Beta command not yet implemented');
   }
 }
diff --git a/src/commands/force/package/beta/version/displayancestry.ts b/src/commands/force/package/beta/version/displayancestry.ts
@@ -38,8 +38,8 @@ export class PackageVersionDisplayAncestryCommand extends SfdxCommand {
     }),
   };
 
+  // eslint-disable-next-line @typescript-eslint/require-await
   public async run(): Promise<unknown> {
-    process.exitCode = 1;
-    return Promise.resolve('Not yet implemented');
+    throw new Error('Beta command not yet implemented');
   }
 }
diff --git a/src/commands/force/package/beta/version/list.ts b/src/commands/force/package/beta/version/list.ts
@@ -53,8 +53,8 @@ export class PackageVersionListCommand extends SfdxCommand {
     }),
   };
 
+  // eslint-disable-next-line @typescript-eslint/require-await
   public async run(): Promise<unknown> {
-    process.exitCode = 1;
-    return Promise.resolve('Not yet implemented');
+    throw new Error('Beta command not yet implemented');
   }
 }
diff --git a/src/commands/force/package/beta/version/update.ts b/src/commands/force/package/beta/version/update.ts
@@ -51,8 +51,8 @@ export class PackageVersionUpdateCommand extends SfdxCommand {
     }),
   };
 
+  // eslint-disable-next-line @typescript-eslint/require-await
   public async run(): Promise<unknown> {
-    process.exitCode = 1;
-    return Promise.resolve('Not yet implemented');
+    throw new Error('Beta command not yet implemented');
   }
 }