Merge pull request #723 from salesforcecli/mradul/packaging/W-1539872…

…4/fix-verbose @W-15398724@ Remove codeCoverage field from non-verbose query response for package version list
salesforcecli · Jul 11, 2024 · dc42ab9 · dc42ab9
2 parents 5bc8207 + 1f65603
commit dc42ab9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/commands/package/version/list.ts b/src/commands/package/version/list.ts
@@ -148,12 +148,17 @@ export class PackageVersionListCommand extends SfCommand<PackageVersionListComma
           record.AncestorId = 'N/A';
         }
 
-        const codeCoverage =
-          record.CodeCoverage?.apexCodeCoveragePercentage != null
+        function getCodeCoverage(): string {
+          if (!flags.verbose) {
+            return 'use --verbose for code coverage';
+          }
+
+          return record.CodeCoverage?.apexCodeCoveragePercentage != null
             ? `${record.CodeCoverage.apexCodeCoveragePercentage.toString()}%`
             : Boolean(record.Package2.IsOrgDependent) || record.ValidationSkipped
             ? 'N/A'
             : '';
+        }
 
         const hasPassedCodeCoverageCheck =
           record.Package2.IsOrgDependent === true || record.ValidationSkipped
@@ -192,7 +197,7 @@ export class PackageVersionListCommand extends SfCommand<PackageVersionListComma
           CreatedDate: new Date(record.CreatedDate).toISOString().replace('T', ' ').substring(0, 16),
           LastModifiedDate: new Date(record.LastModifiedDate).toISOString().replace('T', ' ').substring(0, 16),
           InstallUrl: INSTALL_URL_BASE.toString() + record.SubscriberPackageVersionId,
-          CodeCoverage: codeCoverage,
+          CodeCoverage: getCodeCoverage(),
           HasPassedCodeCoverageCheck: hasPassedCodeCoverageCheck as string | boolean,
           ValidationSkipped: record.ValidationSkipped,
           ValidatedAsync: record.ValidatedAsync,

diff --git a/test/commands/package/packageVersion.nut.ts b/test/commands/package/packageVersion.nut.ts
@@ -309,7 +309,7 @@ describe('package:version:*', () => {
     });
     it('should list package versions in dev hub - json results', () => {
       const command = `package:version:list -v ${session.hubOrg.username} --json`;
-      const output = execCmd<[PackageVersionListCommandResult]>(command, { ensureExitCode: 0 }).jsonOutput?.result;
+      const output = execCmd<PackageVersionListCommandResult>(command, { ensureExitCode: 0 }).jsonOutput?.result;
       const keys = [
         'Package2Id',
         'Branch',
@@ -345,7 +345,10 @@ describe('package:version:*', () => {
       ];
       expect(output).to.have.length.greaterThan(0);
       expect(output?.at(0)).to.have.keys(keys);
+      const codeCoverage = output?.[0]?.CodeCoverage;
+      expect(codeCoverage).to.equal('use --verbose for code coverage');
     });
+
     it('should list package versions in dev hub - verbose json results', () => {
       const command = `package:version:list --verbose -v ${session.hubOrg.username} --json`;
       const output = execCmd<PackageVersionListCommandResult>(command, { ensureExitCode: 0 }).jsonOutput