Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: async validation for package version create #687

Merged
merged 11 commits into from
Jun 18, 2024

Conversation

mradulsf
Copy link
Collaborator

What does this PR do?

What issues does this PR fix or reference?

@mradulsf mradulsf requested a review from a team as a code owner June 11, 2024 22:43
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Mradul Agrawal <m***@m***.i***.s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

@mradulsf mradulsf force-pushed the mradul/managed-packaging/W-15103954/async-validation branch from 9dab53f to 19357af Compare June 11, 2024 23:30
Copy link
Contributor

@shetzel shetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We rely heavily on tests and specifically NUTs to ensure correct packaging command behavior. Please add some so we know it's working properly and can catch regressions.

src/commands/package/version/create.ts Outdated Show resolved Hide resolved
src/commands/package/version/create.ts Show resolved Hide resolved
@shetzel shetzel merged commit 2b961dc into main Jun 18, 2024
12 of 14 checks passed
@shetzel shetzel deleted the mradul/managed-packaging/W-15103954/async-validation branch June 18, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants