Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Package Push Upgrade List command #853

Conversation

btrn11
Copy link
Collaborator

@btrn11 btrn11 commented Dec 12, 2024

What does this PR do?

What issues does this PR fix or reference?


# description

Shows the details of each request to create a package version in the Dev Hub org.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to update here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this whole file could probably be updated. If you just change package version create with package pushupgrade it should be pretty good.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I haven't updated this file except for the first line as placeholder. I'll update it.

}
}

// function fetchVerboseData(results: PackagePushRequestListResultArr): PackagePushRequestListResultArr {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we actually do check in let's not have commented out code. We will just check it in later if we need it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, will clean this up upon check in

@btrn11 btrn11 changed the base branch from main to packagingDistribution/pushUpgradeCLI December 16, 2024 21:49
@btrn11 btrn11 marked this pull request as ready for review January 2, 2025 20:56
@btrn11 btrn11 requested a review from a team as a code owner January 2, 2025 20:56
.gitignore Outdated
@@ -48,3 +48,5 @@ node_modules
.DS_Store
.idea
.iml

.sfdx
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be changing this file.


# flags.verbose.summary

Displays additional information at a slight performance cost, such as number of orgs scheduled for push upgrade, orgs successfully upgraded, etc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably wouldn't mention the performance cost, but we can ask Penelope.


# flags.package-id.summary

Status of the push upgrade request, used to filter the list.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this text is incorrect as it is referencing status instead of package?

@btrn11 btrn11 merged commit 0e35681 into packagingDistribution/pushUpgradeCLI Jan 15, 2025
6 of 10 checks passed
@btrn11 btrn11 deleted the t/packaging-distribution/W-17409033/provide-detailed-list-info-push-upgrade branch January 15, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants