-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Package Push Upgrade List command #853
feat: Package Push Upgrade List command #853
Conversation
messages/package_pushupgrade_list.md
Outdated
|
||
# description | ||
|
||
Shows the details of each request to create a package version in the Dev Hub org. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to update here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this whole file could probably be updated. If you just change package version create with package pushupgrade it should be pretty good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I haven't updated this file except for the first line as placeholder. I'll update it.
} | ||
} | ||
|
||
// function fetchVerboseData(results: PackagePushRequestListResultArr): PackagePushRequestListResultArr { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we actually do check in let's not have commented out code. We will just check it in later if we need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, will clean this up upon check in
.gitignore
Outdated
@@ -48,3 +48,5 @@ node_modules | |||
.DS_Store | |||
.idea | |||
.iml | |||
|
|||
.sfdx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be changing this file.
messages/package_pushupgrade_list.md
Outdated
|
||
# flags.verbose.summary | ||
|
||
Displays additional information at a slight performance cost, such as number of orgs scheduled for push upgrade, orgs successfully upgraded, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably wouldn't mention the performance cost, but we can ask Penelope.
…distribution/W-17409033/provide-detailed-list-info-push-upgrade
messages/package_pushupgrade_list.md
Outdated
|
||
# flags.package-id.summary | ||
|
||
Status of the push upgrade request, used to filter the list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this text is incorrect as it is referencing status instead of package?
0e35681
into
packagingDistribution/pushUpgradeCLI
What does this PR do?
What issues does this PR fix or reference?