Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add proxy support for aws upload #198

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Conversation

peternhale
Copy link
Contributor

What does this PR do?

Add a proxy agent to the S3 connection

What issues does this PR fix or reference?

@W-0@

@peternhale peternhale requested a review from mdonnalley June 15, 2021 13:28
@uip-robot-zz
Copy link

Git2Gus App is installed but the .git2gus/config.json doesn't exist.

Copy link
Contributor

@mshanemc mshanemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about got/proxies to have much of an opinion on this one.

@peternhale peternhale merged commit 9a3bbd7 into main Jun 15, 2021
@peternhale peternhale deleted the phale/s3-proxy-support branch June 15, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants