Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve code coverage percentage output #934

Closed

Conversation

AllanOricil
Copy link
Contributor

@AllanOricil AllanOricil commented Aug 18, 2023

What does this PR do?

It adds the following changes to the table formatter responsible for formatting code coverage percentages

  • when code coverage percentage < 75 -> red
  • when code coverage percentage >= 90 -> green
  • when code coverage percentage >= 75 & < 90 -> yellow

What issues does this PR fix or reference?

forcedotcom/cli#2412

@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Allan Gonçalves Gomes Oricil <a***@r***.local>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

@AllanOricil AllanOricil changed the title feat: improve code coverage percentage outputs and add yellow color feat: improve code coverage percentage output Aug 18, 2023
@AllanOricil
Copy link
Contributor Author

forcedotcom/cli#2412

@mshanemc
Copy link
Contributor

merged into #950

@mshanemc mshanemc closed this Sep 14, 2023
@mshanemc
Copy link
Contributor

@AllanOricil #950 fixes a bug that was right next to this code you wanted to change, so we're pulling this enhancement into that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants