Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allowList in prompt output #545

Merged
merged 2 commits into from
Jul 31, 2023
Merged

feat: allowList in prompt output #545

merged 2 commits into from
Jul 31, 2023

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Jul 31, 2023 •
edited
Loading

What does this PR do?

when people manually confirm unsigned plugins, log to the console info and a link about how to use the allowList.

What issues does this PR fix or reference?

@W-13855118@

@git2gus
Copy link

git2gus bot commented Jul 31, 2023

This issue has been linked to a new work item: W-13855118

@shetzel
Copy link
Contributor

shetzel commented Jul 31, 2023

QA
✅ install a plugin that is signed. Expect no allowlist message.
✅ install a plugin that is not signed. Expect the allowlist message.
✅ install a plugin that is allow listed. Expect no allowlist message.

@shetzel shetzel merged commit 67cdb19 into main Jul 31, 2023
12 of 13 checks passed
@shetzel shetzel deleted the sm/allowList-in-output branch July 31, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shetzel shetzel shetzel approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshanemc @shetzel