Update table #1133
Merged
Update table #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonnalley
requested changes
Oct 22, 2024
package.json
Outdated
| @@ -7,7 +7,7 @@ | |||
| "dependencies": { | |||
| "@salesforce/core": "^8.6.1", | |||
| "@salesforce/kit": "^3.2.2", | |||
| "@salesforce/sf-plugins-core": "^11.3.12", | |||
| "@salesforce/sf-plugins-core": "^12", | |||
There was a problem hiding this comment.
try using ^12.0.7 here to get the failing windows tests to pass
| this.styledHeader('Permsets Assigned'); | ||
| this.table(this.successes, { name: { header: 'Username' }, value: { header: 'Permission Set Assignment' } }); | ||
| this.styledHeader('Partial Success'); |
There was a problem hiding this comment.
why did this styled header move below the Permsets Assigned one? Also, should the Permsets Assigned header be removed?
mdonnalley
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
update table
What issues does this PR fix or reference?
@W-16736207@