Merge branch 'master' into astorm#476-Crud_Improvements

.travis.yml

@@ -21,8 +21,7 @@ language: php
 sudo: required
 dist: trusty
 php:
-   - 5.6
-   - 7.0
+    - 7.1
 before_script:
     # some useful debugging stuff for travis
     #- curl http://magento-2-travis.dev/index.php
@@ -91,6 +90,21 @@ before_script:
     # test that magento is installed
     - curl "$PULSESTORM_MAGE2_FAKE_URL/index.php"
     - pestle.phar hello_world
+    # phpcs install and generating a module for same
+
+    # generate the code for phpcs
+    - ../travis/for-lint.sh
+
+    # leave m2 folder
+    - cd ..
+
+    # install phpcs
+    - mkdir phpcs/
+    - cd phpcs/
+    - echo "{}" > composer.json
+    - composer require magento/magento-coding-standard -vvv
+
+    # return to the base folder and composer install pestle
     - cd ..
     - composer install
 script:
@@ -99,3 +113,7 @@ script:
     # integration tests
     - cd magento2
     - vendor/bin/phpunit vendor/pulsestorm/pestle/tests-integration
+    # run phpcs
+    - cd ../phpcs
+    - find ../magento2/app/code/Pulsestorm
+    - vendor/bin/phpcs vendor/bin/phpcs --standard=vendor/magento/magento-coding-standard/Magento2/ ../magento2/app/code/Pulsestorm/Travis

composer.json

@@ -13,7 +13,8 @@
     "require-dev": {
         "phpunit/phpunit": "4.8.*",
         "phing/phing": "2.*",
-        "phpspec/prophecy":"1.7.0"
+        "phpspec/prophecy":"1.7.0",
+        "magento/magento-coding-standard": "^4.0"
     },
     "autoload": {
         "files": ["library/autoload.php"]

travis/for-lint.sh

@@ -0,0 +1,14 @@
+#!/bin/bash
+
+## Our travis CI/CD will run this script from the root of a Magento
+## folder.  Put pestle commands here to generate code in the
+## Pulsestorm_Travis module.  At the end of the CI we'll run phpcs
+## against this folder to ensure generate code
+
+
+## putting some basic files in place so we can merge and tackle
+## the "phpcs-ification" of things in stages
+mkdir -p app/code/Pulsestorm/Travis
+printf "<?php\nnamespace Pulsestorm\\Travis;\n\nclass Foo\n{\n}\n"  > app/code/Pulsestorm/Travis/Test.php
+
+# pestle.phar magento2:generate:crud-model Pulsestorm_Travis Thing