-
Notifications
You must be signed in to change notification settings - Fork 190
Call cycle_fn for every iteration
#1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #1021 will not alter performanceComparing Summary
|
e05d3ce to
61bdac4
Compare
d4d155c to
e266736
Compare
e266736 to
86aa28f
Compare
carljm
approved these changes
Nov 4, 2025
Contributor
carljm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Contributor
Author
|
I'd appreciate a thumbs up from @mtshiba on this change before merging, considering that it's a breaking change. I, unfortunately, can't request review from you |
ibraheemdev
approved these changes
Nov 4, 2025
Contributor
|
LGTM! |
mtshiba
added a commit
to mtshiba/ruff
that referenced
this pull request
Nov 5, 2025
mtshiba
added a commit
to mtshiba/salsa
that referenced
this pull request
Nov 11, 2025
There was actually no need to run `recover_from_cycle` if the query is converged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes when salsa calls
cycle_fn.Before: Salsa only called
cycle_fnwhen the last provisional and current value were different (this cycle head hasn't converged)Now: Salsa will call
cycle_fnfor every iterationThis feels more consistent for a cycle with nested cycles because, before, a query could have converged but kept being executed
because one of the other heads in this cycle hasn't converged yet.
Always calling the
cycle_fnalso has the benefit that users can use it to finalize the query result.This also makes
CycleRecoveryActionredundant because there's no real difference betweenIterateandFallback. That's why this PR changes thecycle_fnsignature to take an ownedvalueand returnSelf::Output.