chore: fix completions in #[salsa::tracked]
functions
#653
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows rust-analyzer (and, I assume RustRover) to provide accurate completions inside of a
#[salsa::tracked]
function. Previously, I'd comment out the#[salsa::tracked]
annotation when writing a tracked function, but this PR removes the need for that workaround.As @Veykril put it, the core issue is that rust-analyzer's
mbe
crate is not very error-resilient: we no longer pick the correct match arm of themacro_rules
macro because the input doesn't match—mbe
should pick the closest match instead of giving up, but untilmbe
supports that, this PRpapers over a rust-analyzer weakness🌟 it makes the macro more IDE friendly 🌟 !(Credit goes to Lukas for the tip, explanation, and joke!)