-
Notifications
You must be signed in to change notification settings - Fork 195
fix: Delete not re-created tracked structs after fixpoint iteration #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MichaReiser
merged 7 commits into
salsa-rs:master
from
MichaReiser:diff-tracked-structs-cycle
Aug 19, 2025
Merged
fix: Delete not re-created tracked structs after fixpoint iteration #979
MichaReiser
merged 7 commits into
salsa-rs:master
from
MichaReiser:diff-tracked-structs-cycle
Aug 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #979 will improve performances by 5.17%Comparing Summary
Benchmarks breakdown
|
Contributor
Author
|
@carljm Could you take a look at this? |
carljm
approved these changes
Aug 19, 2025
Contributor
carljm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, not sure how I missed this. Looks good, thank you! Needs a clippy expect in the test.
8cdb20e to
8b7e3b9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression that I introduced with #969
#969 moves the tracked structs out from
QueryRevisions::originand instead tracks the "alive" tracked ids directly inIdentityMap. Completing theIdentityMapthen returns to vecs:Unlike before #969, the not re-created tracked struct ids are identified eagerly when completing the query. This isn't an issue for non-cyclic queries but it resulted in leaking if a cyclic query didn't create all tracked structs in the first iteration of the second revision.
This is fixed in this PR. I added a regression test and verified that the logs match the behavior before we merged #969.