Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to opt out of classic component patching #251

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Allow to opt out of classic component patching #251

merged 1 commit into from
Nov 19, 2021

Conversation

SergeAstapov
Copy link
Contributor

opt-in to address #237 until a breaking release is made.

This would allow you to specify:

  let app = new EmberAddon(defaults, {
    cssModules: {
      patchClassicComponent: false
    }
  });

Avoid the deprecation Reopening the Ember.Component super class itself is deprecated if you do not use classic components (or the bindings on classic components, at least).

Thanks to @Turbo87 and @mydea for idea.

Closes #237.

@SergeAstapov
Copy link
Contributor Author

Wonder if @jamescdavis or @dfreeman may release as a new patch version to help upgrading apps and prepare for Ember v4

@SergeAstapov
Copy link
Contributor Author

This similar to #241 but allows to opt-out of monkey-patching behavior before v2 of this addon gets released

@dfreeman
Copy link
Member

Thank you @SergeAstapov! I'm not sure why CI isn't running here, but I'm aiming to get a minor release out with this today and hopefully a major v2 with the monkeypatching and other old crusty stuff removed entirely soon thereafter!

@dfreeman dfreeman merged commit e5cea56 into salsify:master Nov 19, 2021
@SergeAstapov SergeAstapov deleted the fn/opt-out-ember-global branch November 19, 2021 13:33
@SergeAstapov
Copy link
Contributor Author

@dfreeman thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn off Component.reopen() call
2 participants