fix(esm): dont depend on __dirname
#1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
approved these changes
Jun 21, 2024
|
fucking finally |
|
@aprendendofelipe Is ESM working now? If so, I could proceed with new, other features and bugfixes |
|
Everything ok in my tests |
jraoult
reviewed
Jun 25, 2024
| // @ts-expect-error: ignore until esm only | ||
| import.meta.url || __dirname | ||
| ); | ||
| const crossRequire = createRequire(resolve('_')); |
There was a problem hiding this comment.
@aprendendofelipe I've been following the with interest the work on ESM support here. I was reading the code but can't figure out what this does. Specifically, is this underscore (_) a special directory?
Can you help just so that I earn something today 😉🙏
There was a problem hiding this comment.
It is explained in the thread #1206 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1167