Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some tests #2

Closed
wants to merge 6 commits into from
Closed

Conversation

voyvodov
Copy link
Contributor

@voyvodov voyvodov commented Dec 4, 2023

fixing templated testing policies

To allow writing under specific key we need to wildcard it (e.g. allow any
subkey)
Also, to work correctly root key must
also present (e.g. store/metadata/*)

Fixing SDB tests.

Templated tests needs approle to work (token doesn't contain metadata).
Also fixing --local test to provide vault token in minion file (as
it cannot get such from master during local run)

removing v 0.9.6 from tests

This version is very old and out of support years ago.
The oldest version currently supported is 1.8.x, so probably 1.3.x
should be removed too.

To allow writing under specific key we need to wildcard it (e.g. allow any
subkey)
Also, to work correctly root key must
also present (e.g. store/metadata/*)
Templated tests needs approle to work (token doesn't contain metadata).
Also fixing --local test to provide vault token in minion file (as
it cannot get such from master during local run)
This version is very old and out of support years ago.
The oldest version currently supported is 1.8.x, so probably 1.3.x
should be removed too.
@voyvodov
Copy link
Contributor Author

voyvodov commented Dec 7, 2023

Add few fixes for the docs

@lkubb
Copy link
Member

lkubb commented Dec 8, 2023

Thanks again for working on this! Some general comments since this touches many things:

The SDB tests can be fixed more simply: 27d9184 (they were just missing the master/minion config setup which broke after the migration)

The master_config stuff in the docstrings is intended to link to the corresponding Salt docs site, which can be made working via e670b3d. Just removing the :master_config: directive is a bandaid imho.

I am all for dropping the old Vault versions in the test suite, but think we should have one initial release with as few differences to current Salt as possible. There's more things I would like to get rid of since we're not bound to Salt core anymore.

You're right that tests for e.g. secret version deletion with templated policies would require more broad permissions, but there aren't any currently. That could be an area for improvement.

The test_sdb_runner should actually test the runner, not the execution module.

@voyvodov
Copy link
Contributor Author

voyvodov commented Dec 8, 2023

I see all the changes are already implemented correctly in #3
so no reason to keep this PR open too.

@voyvodov voyvodov closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants