select repo key package based on grains['os'] #41
Conversation
|
@jdkelleher shouldn't this be mapped within |
|
Hello @jdkelleher, I don't understand what this code is for. Can you explain us your problem or difficulties using thi formula? |
Yes, I guess that's where defaults belong. I can rework this to add defaults for Ubuntu and Linux Mint to the 'map.jinja' file and resubmit. |
|
@jdkelleher please rework and resubmit if you don't mind. |
|
This is not needed - closing pull request. I will be submitting map.jina updates shortly to add Ubuntu defaults. |
|
@jdkelleher You're welcome to introduce the changes in this PR, using the same branch. Rebasing either from your side or we can do that when merging (including squashing). One benefit of doing that is so that the whole discussion is kept together in one place, including the fact that there has been one approving review of this PR. |
yeah...the idea is good, but |
* Use the correct keyring for the OS (a refactor of the changes suggested in saltstack-formulas#41)
* Use the correct keyring for the OS (a refactor of the changes suggested in saltstack-formulas#41)
## [1.7.1](v1.7.0...v1.7.1) (2019-05-27) ### Bug Fixes * **map.jinja+tests:** add correct keyring for the OS ([0ff48e1](0ff48e1)), closes [saltstack-formulas#41](https://github.com/myii/apt-formula/issues/41) ### Continuous Integration * **kitchen+travis:** update testing environment ([3fa2a58](3fa2a58))
## [0.8.1](v0.8.0...v0.8.1) (2019-05-28) ### Bug Fixes * **map.jinja:** typo and lookup order ([eda8517](eda8517)) * **map.jinja+tests:** add correct keyring for the OS ([0ff48e1](0ff48e1)), closes [#41](#41) ### Code Refactoring * Merge branch 'upstream/master' ([1496eed](1496eed)) ### Continuous Integration * **kitchen+travis:** update testing environment ([3fa2a58](3fa2a58)) ### Documentation * **kitchen:** update documentation ([530e22c](530e22c))
Added if/else based on grains['os'] around common keyring packages to pillar.example. Simple change, but makes the example more usable and should promote pulls with additional distribution details.