Skip to content

Conversation

@myii
Copy link

@myii myii commented Jul 21, 2019

  • Automated using ssf-formula (v0.1.0-rc.1)

* Automated using `ssf-formula` (v0.1.0-rc.1)
@daks
Copy link
Member

daks commented Jul 22, 2019

Looks good to me, I merge.

Waiting for more information (and the code! :) about this ssf-formula which looks like the right tool to easily propagate changes.
Are modifications on kitchen.yml completely automated? It seems to me that it can easily break.

@daks daks merged commit 383d4c8 into saltstack-formulas:master Jul 22, 2019
@myii
Copy link
Author

myii commented Jul 22, 2019

@daks Thanks for the merge.

Waiting for more information (and the code! :) about this ssf-formula which looks like the right tool to easily propagate changes.

I'll be putting it up for scrutiny soon and I welcome all feedback and collaboration on it. Because it also involves git operations and preparing the GitHub PRs via. the API (via. user-customisable scripts at the moment), I'm just working out the final parts as we get these first PRs merged (how to clear-up after merges, ready for the next batch of changes).

Are modifications on kitchen.yml completely automated? It seems to me that it can easily break.

kitchen.yml was the biggest challenge. I'll explain more when there's actual code to discuss. In a very general sense, I started by generating a very ugly template at the beginning (Jinja blocks everywhere!), capturing how all of the formulas were using the file. Then it was a fairly simple job of finding the common structure that would work in all cases. At the current time, that will mean a little more duplication (under each suite if there are multiple suites) but it provides a guaranteed structure that can be depended upon. The template is much simpler to work with, with nearly all of the data coming via. the map. I'm confident that it will suit our use-cases with new formulas as well.

@saltstack-formulas-travis

🎉 This PR is included in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants