Skip to content

Commit

Permalink
fix: replace deprecated ui option with ui_config
Browse files Browse the repository at this point in the history
BREAKING CHANGE: This cannot be updated in a non-breaking fashion, but
the least disruptive route was chosen.

BREAKING CHANGE: If both `ui` and `ui_config.enabled` are set,
`ui_config` takes precedence.  Hence, the change may enable the UI on
machines which had previously set `ui` to false. This is arguably better
than defaulting to `false`, which would disable the UI where it is
supposed to be enabled.

BREAKING CHANGE: Removing the option entirely breaks similarly if users
rely on the formula defaults, since Consul's default is `false` and the
formula's default used to be `true`.

BREAKING CHANGE: The only other way to break less would be to set both
options, but then users would also have override both (which is not
obvious and very annoying) and there would still be no way forward to
when Consul actually removes the deprecated option.
  • Loading branch information
phoerious authored Dec 13, 2020
1 parent 7d02d75 commit 3830ade
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
5 changes: 3 additions & 2 deletions consul/defaults.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
consul:
version: 1.3.0
version: 1.9.0
download_host: releases.hashicorp.com

service: false
Expand All @@ -14,7 +14,8 @@ consul:
server: false
bind_addr: 0.0.0.0
data_dir: /var/consul
ui: true
ui_config:
enabled: true
enable_debug: false
log_level: info
encrypt: ""
Expand Down
5 changes: 3 additions & 2 deletions pillar.example
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ consul:
user: consul
group: consul

version: 0.7.0
version: 1.9.0
download_host: releases.hashicorp.com

config:
Expand All @@ -28,7 +28,8 @@ consul:
- 1.1.1.1
- 2.2.2.2

ui: true
ui_config:
enabled: true
log_level: info
data_dir: /var/consul

Expand Down

0 comments on commit 3830ade

Please sign in to comment.