Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkg installed (not latest), allow_updates, version #153

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Use pkg installed (not latest), allow_updates, version #153

merged 1 commit into from
Jun 29, 2018

Conversation

noelmcloughlin
Copy link
Member

Resolves #111

@aboe76
Copy link
Member

aboe76 commented Jun 28, 2018

@noelmcloughlin in #111 there is also the point of version or update

in https://docs.saltstack.com/en/latest/ref/states/all/salt.states.pkg.html#salt.states.pkg.installed
the option to add version and allow_updates: True

@noelmcloughlin noelmcloughlin changed the title Use pkg.installed not latest Use pkg installed (not latest), allow_updates, version Jun 28, 2018
@noelmcloughlin
Copy link
Member Author

noelmcloughlin commented Jun 28, 2018

@aboe76 I never noticed, thanks I have reviewed and updated the commit.

I have introduced new parameters under new docker:pkg namespace - but left depreciated docker-pkg:version pillar intact - future PR needs to cleanup this state, maybe #151

pkg.installed:
{%- if "version" in docker %}
{%- if grains["oscodename"]|lower == 'jessie' %}
- name: docker.io
- version: {{ docker.version }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this the same as docker.pkg.version ?

Copy link
Member Author

@noelmcloughlin noelmcloughlin Jun 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and No. That docker.version is generated by map.jinja and docker-pkg:lookup:version pillar. But docker-pkg namespace is, or should be, depreciated.

There is repetition in the code block - I could fix that but small PR gets too big then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem as long as you have it on your radar, we can merge this one, I rather see small PR's which document the Transitions.

@noelmcloughlin
Copy link
Member Author

Fixed conflicts.

@aboe76 aboe76 merged commit 3d92122 into saltstack-formulas:master Jun 29, 2018
@aboe76
Copy link
Member

aboe76 commented Jun 29, 2018

@noelmcloughlin thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants