-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pkg installed (not latest), allow_updates, version #153
Conversation
@noelmcloughlin in #111 there is also the point of version or update in https://docs.saltstack.com/en/latest/ref/states/all/salt.states.pkg.html#salt.states.pkg.installed |
pkg.installed: | ||
{%- if "version" in docker %} | ||
{%- if grains["oscodename"]|lower == 'jessie' %} | ||
- name: docker.io | ||
- version: {{ docker.version }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this the same as docker.pkg.version ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes and No. That docker.version
is generated by map.jinja and docker-pkg:lookup:version
pillar. But docker-pkg
namespace is, or should be, depreciated.
There is repetition in the code block - I could fix that but small PR gets too big then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem as long as you have it on your radar, we can merge this one, I rather see small PR's which document the Transitions.
Fixed conflicts. |
@noelmcloughlin thanks for this. |
Resolves #111