Fix errors on MacOS ('oscodename', configfile) #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noelmcloughlin
changed the title
|
Added commit to fix #209 |
|
Okay - the formula is working on MacOS. |
|
Travis CI fails because of #182 |
noelmcloughlin
requested review from
aboe76 and
javierbertoli
and removed request for
aboe76
|
@javierbertoli are you okay with this PR? |
|
This is well tested - followup PRs can address any issues. Merging per "if your pull request has stayed open for more than a couple days feel free to "selfie-merge" your own." @ community critiera |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround Rendering error on MacOS: saltstack/salt#53317
Verified on MacOS