-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it easier when using salt-ssh #214
Make it easier when using salt-ssh #214
Conversation
…ing to set --extra-filerefs when using the formula with salt-ssh.
Skipping acquire of configured file 'stable/binary-i386/Packages' as repository 'https://download.docker.com/linux/ubuntu bionic InRelease' doesn't support architecture 'i386' Adding [arch=<osarch>] between deb and https solved this problem.
I've added a fix for the sources list. |
Skipping acquire of configured file 'stable/binary-i386/Packages' as repository 'https://download.docker.com/linux/ubuntu bionic InRelease' doesn't support architecture 'i386' Adding [arch=<osarch>] between deb and https solved this problem.
# Conflicts: # docker/repo.sls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please confirm when re-tested successfully and I am happy to merge.
thanks @remichristiaan
Travis failed, seems not all packages are installed, complained about not having jinja/yaml. |
See #182 ;-) . If you could test manually that would be appreciated. |
Tested on my dev env with salt-ssh ... no problems observed. |
Thanks @remichristiaan for this. |
I've ran more tests and there is a hitch ... need to add some code in other places too. Sorry, tomorrow I'll send in the right pull-request. |
No problem - I have reverted. |
@remichristiaan I'm aware that this PR has been reverted in #215. As a note, the canonical source to refer back to is https://github.com/saltstack-formulas/template-formula/blob/master/template/map.jinja. This has been crafted to work for |
Using the tplroot method (borrowed from the ufw-formula) prevents having to set --extra-filerefs when using the formula with salt-ssh.
I've only tested it on my own salt deployment which worked without a hitch.