Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(kitchen): use fail2ban.ng in state_top #39

Merged
merged 2 commits into from
Jan 10, 2020

Conversation

myii
Copy link
Member

@myii myii commented Jan 10, 2020

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Also contains a bug fix for the ng:lookup.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@myii myii force-pushed the ci/use-fail2ban.ng-in-kitchen branch from b826d28 to 10b403f Compare January 10, 2020 21:50
@myii myii merged commit f7f12d0 into saltstack-formulas:master Jan 10, 2020
@myii myii deleted the ci/use-fail2ban.ng-in-kitchen branch January 10, 2020 22:03
@myii
Copy link
Member Author

myii commented Jan 10, 2020

Self-merging mainly because the build was failing with the mess of the situation as discussed in #37 and #35. Needs to be done anyway with the plan to promote ng.

@saltstack-formulas-travis

🎉 This PR is included in version 0.17.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants