Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(kitchen+travis): add kitchen tests #9

Merged
merged 2 commits into from
May 27, 2019
Merged

ci(kitchen+travis): add kitchen tests #9

merged 2 commits into from
May 27, 2019

Conversation

n-rodriguez
Copy link
Member

No description provided.

@n-rodriguez n-rodriguez requested a review from myii May 27, 2019 00:49
@myii
Copy link
Member

myii commented May 27, 2019

@n-rodriguez Tests are failing at the moment. And is it worth using the "tree"-shaped matrix from template-formula?

myii
myii requested changes May 27, 2019
View reviewed changes
Copy link
Member

@myii myii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .gitignore change is not important. More important is to include the change to README.rst, where we explain how to use bin/kitchen. Could we also move that to a docs sub-directory?

.gitignore Show resolved Hide resolved
@myii
Copy link
Member

myii commented May 27, 2019

OK, that was a powerful response! Since this is now semantic-release, I'll need to run a few more checks and get back to you.

myii
myii approved these changes May 27, 2019
View reviewed changes
Copy link
Member

@myii myii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the Testing/Requirements section missing in the README but I'll submit that in a PR for you to review.

@myii myii merged commit b011bdb into saltstack-formulas:master May 27, 2019
@myii
Copy link
Member

myii commented May 27, 2019

@n-rodriguez Merged, how many is that now? Fantastic work, thanks. @daks You're falling behind!!

@myii myii mentioned this pull request May 27, 2019
Open
71 tasks
@saltstack-formulas-travis
Copy link

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@n-rodriguez n-rodriguez deleted the wip/kitchen branch August 25, 2019 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daks daks daks left review comments

@myii myii myii approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@n-rodriguez @myii @saltstack-formulas-travis @daks