Semantic release #44
Merged
Semantic release #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-rodriguez
reviewed
Jun 19, 2019
| @@ -0,0 +1,4 @@ | |||
|
|
|||
| cron_package: | |||
There was a problem hiding this comment.
great work @daks! but isn't it the logrotate formula? ;)
There was a problem hiding this comment.
This state is added for Suse platforms only at kitchen run, because Suse image does not seems to have cron installed. As logrotate directly depends on cron running, test fails :)
There was a problem hiding this comment.
@javierbertoli Would it be worth adding cron to the Suse pre-salted images?
aboe76
approved these changes
Jun 19, 2019
|
@myii new version with asked changes. |
myii
approved these changes
Jun 25, 2019
|
Excellent, thanks @daks -- merged. Appreciate the reviews @aboe76 and @n-rodriguez. |
71 tasks
|
🎉 This PR is included in version 0.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
thanks everyone for the review and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement semantic-release with a special test fix for Suse
os_family.