Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated testing is failing on this formula #19

Closed
myii opened this issue Apr 17, 2020 · 6 comments · Fixed by #20
Closed

Automated testing is failing on this formula #19

myii opened this issue Apr 17, 2020 · 6 comments · Fixed by #20
Labels

Comments

@myii
Copy link
Member

myii commented Apr 17, 2020

@noelmcloughlin I run weekly tests of all converted formulas against Salt's master branch, as additional QA. The lvm-formula has been passing up until this week:

When it failed this week, I also tested it against 3000.1 as well as 2019.2 but all are failing:

It appears to be the same state failing:

                 ID: lvm_pv_create_/dev/loop4
           Function: lvm.pv_present
               Name: /dev/loop4
             Result: False
            Comment: An exception occurred in this state: Traceback (most recent call last):
                File "/usr/lib/python3/dist-packages/salt/state.py", line 1933, in call
                  **cdata['kwargs'])
                File "/usr/lib/python3/dist-packages/salt/loader.py", line 1951, in wrapper
                  return f(*args, **kwargs)
                File "/usr/lib/python3/dist-packages/salt/states/lvm.py", line 66, in pv_present
                  changes = __salt__['lvm.pvcreate'](name, **kwargs)
                File "/usr/lib/python3/dist-packages/salt/modules/linux_lvm.py", line 255, in pvcreate
                  raise CommandExecutionError(out.get('stderr'))
              salt.exceptions.CommandExecutionError:   WARNING: Failed to connect to lvmetad. Falling back to device scanning.
                Can't open /dev/loop4 exclusively.  Mounted filesystem?

Note, this is also causing the iscsi-formula testing to fail, since it uses the lvm-formula as a dependency.


References:

@noelmcloughlin
Copy link
Member

Hi, @myii I'll have a look at this when I get time. I think I recall some issue in the past when trying to guess names of the loop devices. Possibly some Docker container parameter changed. The tests or states may need to be redesigned to remove the guesswork. thanks

@noelmcloughlin
Copy link
Member

noelmcloughlin commented Apr 19, 2020 via email

@myii
Copy link
Member Author

myii commented Apr 19, 2020

@noelmcloughlin Nice, I'll try to get around to it soon. Does iscsi work for the other platforms, though?

@noelmcloughlin
Copy link
Member

noelmcloughlin commented Apr 19, 2020 via email

@noelmcloughlin
Copy link
Member

PRs raised to fix things:
LVM: #20
ISCSI: saltstack-formulas/iscsi-formula#35

@saltstack-formulas-travis

🎉 This issue has been resolved in version 0.3.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants