Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update python packages for onedir #278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

didiermfb
Copy link

@didiermfb didiermfb commented Nov 15, 2023

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Make the formula compatible with onedir

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Add packages and python module to make the formula compatible with onedir

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@didiermfb didiermfb changed the title update python packages for onedir feat: update python packages for onedir Nov 16, 2023
@didiermfb didiermfb force-pushed the didiermfb-python-onedir branch from 1e9b120 to 0bd36e8 Compare November 16, 2023 09:19
@sylvainfaivre
Copy link

Yesterday in the formulas working group meeting, he had a chat about formulas compatibility with onedir packaging, and the shared opinion was that formulas should be updated to support onedir. Legacy release support may be dropped (this will then be a BREAKING CHANGE), as people willing to use legacy releases can point to older formulas releases.

Regarding the packages to install, I think your code is only compatible with Debian-based distributions. You should use map.jinja and related yaml files to install the required packages according to the OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants