Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sshd_config): drop obsolete comment (fixes #120) #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alxwr
Copy link
Member

@alxwr alxwr commented Feb 9, 2024

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

#120

Describe the changes you're proposing

Remove a misleading comment.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

----------
          ID: sshd_config
    Function: file.managed
        Name: /etc/ssh/sshd_config
      Result: None
     Comment: The file /etc/ssh/sshd_config is set to be changed
              Note: No changes made, actual changes may
              be different due to other states.
     Started: 02:09:22.861195
    Duration: 150.767 ms
     Changes:   
              ----------
              diff:
                  --- 
                  +++ 
                  @@ -1,7 +1,4 @@
                   # This file is managed by salt. Manual changes are going to be overwritten.
                  -# The contents of the original sshd_config are kept on the bottom for
                  -# quick reference.
                  -# See the sshd_config(5) manpage for details
                   
                   Port 22
                   Protocol 2
----------
          ID: openssh
    Function: service.running
        Name: sshd
      Result: None
     Comment: Service is set to be restarted
     Started: 02:09:23.132870
    Duration: 55.057 ms
     Changes:

Summary for host.domain.tld
-------------
Succeeded: 12 (unchanged=2, changed=1)
Failed:     0
-------------
Total states run:     12
Total run time:    2.959 s

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@alxwr alxwr requested a review from baby-gnu February 9, 2024 01:13
@alxwr alxwr self-assigned this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants