tunnels are restarted every time highstate runs #119

cmclaughlin · 2019-09-07T04:56:29Z

I recently upgraded to the latest version of this formula for systemd suppor (on AWS Linux 2).

And I noticed every time I run highstate my tunnels are restarted.

          ID: obsolete_openvpn_employees-udp-1194_service
    Function: service.dead
        Name: openvpn@employees-udp-1194
      Result: True
     Comment: Service openvpn@employees-udp-1194 has been disabled, and is dead
     Started: 04:51:09.669200
    Duration: 250.489 ms
     Changes:
              ----------
              openvpn@employees-udp-1194:
                  True
----------
          ID: openvpn_employees-udp-1194_service
    Function: service.running
        Name: openvpn@employees-udp-1194
      Result: True
     Comment: Service openvpn@employees-udp-1194 has been enabled, and is running
     Started: 04:51:10.094798
    Duration: 254.426 ms
     Changes:
              ----------
              openvpn@employees-udp-1194:
                  True

In service.sls there's a comment "For an successful upgrade we need to make sure the old services are deactivated". I guess there's a bug on the name of the old service though? It's not clear what case we're trying to cover here. Perhaps we can just delete the entire service.dead block?

The text was updated successfully, but these errors were encountered:

cmclaughlin · 2019-09-09T19:20:56Z

@aboe76 I noticed you added service.dead in #110. I don't have any BSD or Debian hosts... and it's not clear what upgrade case you were working on. Do your tunnels get restarted every time highstate is applied?

n-rodriguez · 2019-09-09T21:28:02Z

it's not clear what upgrade case you were working on

migration from openvpn@service to openvpn-server@service systemd units.

cmclaughlin · 2019-09-09T21:34:36Z

Ok, so I suppose there's a bug such that I ended up with openvpn@service not openvpn-server@service - on AWS Linux 2.

myii · 2019-09-09T22:19:33Z

Just a quick note, we've got Amazon Linux 2 configured in kitchen.yml but it isn't currently enabled in Travis. Looking back through the build history, there's a failure at the installation stage:

https://travis-ci.org/myii/openvpn-formula/jobs/574197634#L875:

                 ID: openvpn_pkgs
           Function: pkg.installed
             Result: False
            Comment: Error occurred installing package(s). Additional info follows:
              
              errors:
                  - Running scope as unit run-261.scope.
                    Loaded plugins: ovl, priorities
                    No package openvpn available.
                    Error: Nothing to do

@cmclaughlin Did you already have openvpn installed before using this formula? Could you suggest the improvements needed to get the installation working here?

cmclaughlin · 2019-09-09T22:24:20Z

Did you already have openvpn installed before using this formula? Could you suggest the improvements needed to get the installation working here?

Yes and no...

I had an older EC2 instance running that was built off an older version of this formula. I ran a highstate with test=True and saw too many changes to feel comfortable proceeding. So I launched a new instance off the latest version of the formula.

So basically, no, I didn't perform the upgrade.

myii · 2019-09-09T22:26:03Z

@cmclaughlin Do you know what the package name is on Amazon Linux 2?

cmclaughlin · 2019-09-09T22:27:41Z

The package name is just openvpn - installed from EPEL 7.

myii · 2019-09-09T22:28:59Z

OK, thanks. The repo will need to be enabled to install the package.

myii · 2019-09-10T19:36:41Z

@cmclaughlin Thanks, adding the repo worked:

https://travis-ci.org/myii/openvpn-formula/builds/583326179

@javierbertoli Can the EPEL repo be added to the pre-salted images or should we really be installing the repo using this formula before package installation?

daks · 2019-09-11T15:28:55Z

I think if a repo is needed to run this formula:

we can choose to not manage it, but it means that doc/README/pillar.example should be explicit about the need to have this repo configured previously
choose to manage it, but it needs to be possible to not use it, so a separate state or a pillar to not use it. This is necessary so that anyone can use its own method to manage repos

myii · 2019-09-11T15:41:54Z

@daks I had a search through the whole SaltStack Formulas organisation, to see what other formulas do. There are one or two (e.g. zfs-formula), which actually use the epel-formula as a dependency but that's not recommended here. Quite a few use the epel-formula as a dependency in Kitchen and that may be something worth considering. I couldn't find an example of using pkgrepo for this. Probably because it can be configured using:

$ yum install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm

n-rodriguez · 2019-09-11T22:43:08Z

Why not using the repo pattern? saltstack-formulas/php-formula@3c9efc7 https://github.com/saltstack-formulas/php-formula/blob/master/test/salt/pillar/debian.sls#L5

myii · 2019-09-11T22:55:33Z

@n-rodriguez The repo pattern could definitely be useful. The issue right now is getting pkgrepo.managed working for the EPEL repo -- have you got any experience with this?

n-rodriguez · 2019-09-11T23:43:19Z

https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm

The content of https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm should help ;)

There's the key and the repo :

[epel]
name=Extra Packages for Enterprise Linux 7 - $basearch
#baseurl=http://download.fedoraproject.org/pub/epel/7/$basearch
metalink=https://mirrors.fedoraproject.org/metalink?repo=epel-7&arch=$basearch
failovermethod=priority
enabled=1
gpgcheck=1
gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7

[epel-debuginfo]
name=Extra Packages for Enterprise Linux 7 - $basearch - Debug
#baseurl=http://download.fedoraproject.org/pub/epel/7/$basearch/debug
metalink=https://mirrors.fedoraproject.org/metalink?repo=epel-debug-7&arch=$basearch
failovermethod=priority
enabled=0
gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7
gpgcheck=1

[epel-source]
name=Extra Packages for Enterprise Linux 7 - $basearch - Source
#baseurl=http://download.fedoraproject.org/pub/epel/7/SRPMS
metalink=https://mirrors.fedoraproject.org/metalink?repo=epel-source-7&arch=$basearch
failovermethod=priority
enabled=0
gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7
gpgcheck=1

Copy/paste in formula pillars (defaults.yaml and friends) if users can use the new openvpn.repo state or in test pillars (like in php-formula) if the state is not meant to be used.

n-rodriguez · 2019-09-11T23:52:39Z

Copy/paste in formula pillars (defaults.yaml and friends) if users can use the new openvpn.repo state or in test pillars (like in php-formula) if the state is not meant to be used.

From a global perspective, I think it could be nice to implement the repo pattern as soon as the package can be downloaded from a different repo than the distribution.

By default we should rely on distribution packages.

But with the repo pattern, people could feed pillars with the repo they want to use and call the <formula>.repo state when needed.

What do you think?

myii · 2019-09-12T00:46:35Z

@n-rodriguez Thanks for digging into that, great result.

From a global perspective, I think it could be nice to implement the repo pattern as soon as the package can be downloaded from a different repo than the distribution.

By default we should rely on distribution packages.

But with the repo pattern, people could feed pillars with the repo they want to use and call the <formula>.repo state when needed.

What do you think?

I think it's an excellent idea. The macro can distributed using the ssf-formula as well (for ease of long-term maintenance, should it be improved over time). My question is whether it wouldn't be easier to have separate files for each macro rather than a generalised macros.jinja, a bit like how we did with libtofs.jinja? However, perhaps it's not worth it for small, general-purpose macros such as format_kwargs.

myii · 2019-09-12T00:47:25Z

The above links back to: saltstack-formulas/template-formula#134.

daks · 2019-09-12T09:04:32Z

What do you name the repo pattern? Include a repo state and corresponding pillar, so that if user uses this pillar, the state is run to configure the repo?

myii · 2019-09-12T10:37:16Z

@daks Follow the links here: #119 (comment). That was my first introduction to the "repo pattern" as well.

myii · 2019-09-13T19:42:19Z

@n-rodriguez This looks good for the EPEL repo:

Add support for Amazon Linux 2 epel-formula#51

daks · 2019-09-14T08:47:37Z

@myii I saw those links and understand part of what is done, but I don't know this php-formula and wanted a 'high level' view of the functionality. My main concern is to keep the possibility of having an external way of handling a repo and therefore not use the one provided by the formula. Some users will always want to keep their repos managed uniformly accross their minions and not depends on formulas.

myii · 2019-09-14T09:40:52Z

@daks Don't worry, I'm not pushing for formula inter-dependencies, at least not yet! That talk can begin if we get the SPM solution that's been discussed on Slack.

In the meantime, my proposal is to use saltstack-formulas/epel-formula#51 directly in this formula, ideally using the "repo pattern" suggested by @n-rodriguez.

n-rodriguez · 2019-09-14T21:13:37Z

My question is whether it wouldn't be easier to have separate files for each macro rather than a generalised macros.jinja, a bit like how we did with libtofs.jinja? However, perhaps it's not worth it for small, general-purpose macros such as format_kwargs.

I'm for one macro / one file. The best would be to store them in a macros directory.
Easier to maintain, easier to extend/change/evolve, easier to copy/paste from one formula to another.

myii · 2019-09-16T11:19:15Z

@daks @n-rodriguez So I've got it working by making the following modification (ignore the .travis.yml changes, that's just for testing):

That's taken directly from the epel-formula, including saltstack-formulas/epel-formula#51. So it doesn't look like the "repo pattern" is going to work here, unless I'm missing something. Any suggestions on how to proceed with this?

daks · 2019-09-16T11:38:34Z

@daks Don't worry, I'm not pushing for formula inter-dependencies, at least not yet! That talk can begin if we get the SPM solution that's been discussed on Slack.

When I see all commits/merge/releases which generate a single change in template-formula, I still think it may be simpler to have some 'stdlib' one. (as already discussed elsewhere previously)

But my point was not there, I just wanted to understand what does this repo pattern implies.

My main concern is to keep the possibility of having an external way of handling a repo and therefore not use the one provided by the formula. Some users will always want to keep their repos managed uniformly accross their minions and not depends on formulas.

* saltstack-formulas/openvpn-formula#119

myii · 2019-09-19T08:45:19Z

@daks @n-rodriguez Got EPEL repo configured using pkgrepo.managed and enabled amazonlinux-2 in Travis: #122.

myii · 2019-09-19T08:50:42Z

@cmclaughlin What specific states are/were running in your highstate? We can try to reproduce the issue here, as a first step towards fixing it.

cmclaughlin · 2019-09-19T17:30:14Z

Thanks for all of the effort here... my state simply includes:

  - openvpn
  - openvpn.config
  - openvpn.service

* Fix saltstack-formulas#119

myii · 2019-09-20T10:15:47Z

@cmclaughlin I've tested this and it should fix your issue:

myii/openvpn-formula@62fc957...be7dd34

If you can confirm that, I can put a PR in.

* saltstack-formulas/openvpn-formula#119

* Fix saltstack-formulas#119

cmclaughlin · 2019-09-21T17:20:30Z

@myii yes, looks good... thanks!

          ID: openvpn_employees-udp-1194_service
    Function: service.running
        Name: openvpn@employees-udp-1194
      Result: True
     Comment: The service openvpn@employees-udp-1194 is already running
     Started: 17:16:25.315642
    Duration: 38.392 ms
     Changes:

myii · 2019-09-21T21:04:50Z

@cmclaughlin Great, thanks for the confirmation.

* Fix #119

## [0.15.2](v0.15.1...v0.15.2) (2019-09-25) ### Bug Fixes * **service:** stop old service only if name is different to new service ([1724dfd](1724dfd)), closes [#119](#119) ### Continuous Integration * **kitchen:** change `log_level` to `debug` instead of `info` ([e94c9ba](e94c9ba))

saltstack-formulas-travis · 2019-09-25T22:17:39Z

🎉 This issue has been resolved in version 0.15.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.14.0](v1.13.0...v1.14.0) (2020-12-05) ### Bug Fixes * **adapters:** call `adapters.sls` in `init.sls` ([3ebcbe9](3ebcbe9)) * **auth_nocache:** fix typo in client template ([c8f0971](c8f0971)), closes [saltstack-formulas#125](https://github.com/myii/openvpn-formula/issues/125) * **centos:** install OpenSSL on CentOS ([7e4c8d6](7e4c8d6)) * **centos-6:** has only _one_ service 'openvpn' ([3d5723d](3d5723d)) * **config:** configurable distinction between server and client services ([18c4c4a](18c4c4a)) * **config:** script-security is a common option ([b1b482c](b1b482c)) * **config:** set tls-auth and tls-crypt independentyl of ta_content ([d3787b6](d3787b6)) * **config:** sub-mappings for client and server ([b30b23d](b30b23d)) * **config.sls:** fix `salt-lint` errors ([1b3f7f6](1b3f7f6)) * **debian-ish:** root owns the logs ([3276d3b](3276d3b)) * **dhparams:** allow generating Diffie Hellman parameters on Windows ([3802024](3802024)) * **fedora:** honor working directory & service name ([4f8e899](4f8e899)) * **freebsd:** load if_tap module ([d63581a](d63581a)) * **ifconfig_pool_persist.sls:** fix `salt-lint` errors ([6969083](6969083)) * **jinja:** don't call pillar.get ([33b98f5](33b98f5)) * **logging:** set replace=False and add dependencies for log files ([9b71fcf](9b71fcf)) * **macros:** use openvpn/macros.jinja ([637387e](637387e)) * **map.jinja:** fix `salt-lint` errors ([eabfc57](eabfc57)) * **network_manager_networks:** properly override port ([1d58ec6](1d58ec6)) * **network_manager_networks:** reduced pillar.get calls ([7ee9eed](7ee9eed)) * **release.config.js:** use full commit hash in commit link [skip ci] ([81d922d](81d922d)) * **repo:** provide EPEL repo configuration for `Amazon Linux-2` ([bfb29bd](bfb29bd)) * **service:** make sure the now obsolete systemd services are disabled ([2dfae46](2dfae46)) * **service:** removed trailing whitespace ([85d2458](85d2458)) * **service:** stop old service only if name is different to new service ([1724dfd](1724dfd)), closes [saltstack-formulas#119](https://github.com/myii/openvpn-formula/issues/119) * **service:** use OS-specific service name in multi-service setups ([b16756c](b16756c)) * **specs:** use boolean operator ([89fa956](89fa956)) * **tap-adapter.ps1:** work with alternate name `Local Area Connection` ([372b3b6](372b3b6)) * **test:** drop ' then$' ([62c2f70](62c2f70)) * **test:** dropped redundant permission checks ([9c3ea71](9c3ea71)) ### Continuous Integration * **cleanup:** dropped obsolete opensuse-leap-15 workaround ([1e1719d](1e1719d)) * **gemfile:** restrict `train` gem version until upstream fix [skip ci] ([ed6b7f0](ed6b7f0)) * **gemfile.lock:** add to repo with updated `Gemfile` [skip ci] ([0aa9fd6](0aa9fd6)) * **github:** add Windows testing using Actions ([2d4b79c](2d4b79c)) * **gitlab:** test `semantic-release` back to GitHub ([6dcf159](6dcf159)) * **gitlab:** use GitLab CI as Travis CI replacement ([c9e4a8c](c9e4a8c)) * **kitchen:** add kitchen file + testinfra ([9c5ee26](9c5ee26)) * **kitchen:** avoid using bootstrap for `master` instances [skip ci] ([6eb1b44](6eb1b44)) * **kitchen:** change `log_level` to `debug` instead of `info` ([e94c9ba](e94c9ba)) * **kitchen:** install required packages to bootstrapped `opensuse` [skip ci] ([b76dcc9](b76dcc9)) * **kitchen:** rename pillar ([4122fc0](4122fc0)) * **kitchen:** test/config/pillars: add jinja for user on debian >= 9 ([3c7f947](3c7f947)) * **kitchen:** use `debian-10-master-py3` instead of `develop` [skip ci] ([83e00e1](83e00e1)) * **kitchen:** use `develop` image until `master` is ready (`amazonlinux`) [skip ci] ([06a09f2](06a09f2)) * **kitchen:** use `saltimages` Docker Hub where available [skip ci] ([740ba4e](740ba4e)) * **kitchen:** use bootstrapped `opensuse` images until `2019.2.2` [skip ci] ([0db9651](0db9651)) * **kitchen+travis:** modify matrix to include `develop` platform ([91b5798](91b5798)) * **kitchen+travis:** remove `master-py2-arch-base-latest` [skip ci] ([9e7aa34](9e7aa34)) * **kitchen+travis:** replace EOL pre-salted images ([2577535](2577535)) * **kitchen+travis:** upgrade matrix after `2019.2.2` release [skip ci] ([4eb9d3b](4eb9d3b)) * **platform:** add `arch-base-latest` (commented out for now) [skip ci] ([75d7aaa](75d7aaa)) * **pre-commit:** add to formula [skip ci] ([95bbd5e](95bbd5e)) * **pre-commit:** enable/disable `rstcheck` as relevant [skip ci] ([92e02f2](92e02f2)) * **pre-commit:** finalise `rstcheck` configuration [skip ci] ([44e040d](44e040d)) * avoid `init_environment` failing due to saltstack/salt[#57628](https://github.com/myii/openvpn-formula/issues/57628) ([398932b](398932b)) * **specs:** increased readability ([b2c9cf1](b2c9cf1)) * **test data:** moved Pillar test data ([2fff1ee](2fff1ee)) * **testing:** added bin/kitchen ([15bea7b](15bea7b)) * **travis:** add notifications => zulip [skip ci] ([80930cd](80930cd)) * **travis:** apply changes from build config validation [skip ci] ([ea3336a](ea3336a)) * **travis:** exclude Fedora 29 from Travis CI ([4a1f9ed](4a1f9ed)) * **travis:** merge `rubocop` linter into main `lint` job ([9f82955](9f82955)) * **travis:** opt-in to `dpl v2` to complete build config validation [skip ci] ([bb43f31](bb43f31)) * **travis:** quote pathspecs used with `git ls-files` [skip ci] ([667bc1f](667bc1f)) * **travis:** run `shellcheck` during lint job [skip ci] ([9d63e36](9d63e36)) * **travis:** test based on template-formula and [saltstack-formulas#98](https://github.com/myii/openvpn-formula/issues/98) ([b9daf9b](b9daf9b)) * **travis:** update `salt-lint` config for `v0.0.10` [skip ci] ([d465b4f](d465b4f)) * **travis:** use `major.minor` for `semantic-release` version [skip ci] ([4099f15](4099f15)) * **travis:** use build config validation (beta) [skip ci] ([d2f7fe2](d2f7fe2)) * **workflows/commitlint:** add to repo [skip ci] ([5900915](5900915)) * merge travis matrix, add `salt-lint` & `rubocop` to `lint` job ([d7f1607](d7f1607)) * merge travis matrix, add `salt-lint` & `rubocop` to `lint` job ([70dab6c](70dab6c)) * **yamllint:** add rule `empty-values` & use new `yaml-files` setting ([a437b3b](a437b3b)) * use `dist: bionic` & apply `opensuse-leap-15` SCP error workaround ([5e02797](5e02797)) ### Documentation * add steps required for testing using Vagrant ([0229d14](0229d14)) * **contributing:** remove to use org-level file instead [skip ci] ([8703eb5](8703eb5)) * **pillar.example:** update with quoted "yes" for comp-lzo ([1b49b24](1b49b24)) * **readme:** update link to `CONTRIBUTING` [skip ci] ([a72049f](a72049f)) ### Features * **auth_gen_token:** support for auth-gen-token ([333edd7](333edd7)) * **auth_nocache:** support for auth-nocache ([c21b7f5](c21b7f5)) * **syslog:** support for syslog ([24b370c](24b370c)) * **yamllint:** include for this repo and apply rules throughout ([4355ac6](4355ac6)) ### Performance Improvements * **travis:** improve `salt-lint` invocation [skip ci] ([26838e5](26838e5)) ### Tests * **map:** verify `map.jinja` dump using `_mapdata` state ([ecac1b1](ecac1b1)) * add test for auth-nocache option ([79c1055](79c1055)) * **kitchen:** debian and ubuntu use different paths now ([dfd784e](dfd784e)) * **pillar:** set 'status' to fix kitchen tests ([07bb5b6](07bb5b6)) * **windows:** add local testing of Windows using Vagrant/Virtualbox ([96c3001](96c3001))

# [1.14.0](v1.13.0...v1.14.0) (2020-12-05) ### Bug Fixes * **adapters:** call `adapters.sls` in `init.sls` ([3ebcbe9](3ebcbe9)) * **auth_nocache:** fix typo in client template ([c8f0971](c8f0971)), closes [saltstack-formulas#125](https://github.com/myii/openvpn-formula/issues/125) * **centos:** install OpenSSL on CentOS ([7e4c8d6](7e4c8d6)) * **centos-6:** has only _one_ service 'openvpn' ([3d5723d](3d5723d)) * **config:** configurable distinction between server and client services ([18c4c4a](18c4c4a)) * **config:** script-security is a common option ([b1b482c](b1b482c)) * **config:** set tls-auth and tls-crypt independentyl of ta_content ([d3787b6](d3787b6)) * **config:** sub-mappings for client and server ([b30b23d](b30b23d)) * **config.sls:** fix `salt-lint` errors ([1b3f7f6](1b3f7f6)) * **debian-ish:** root owns the logs ([3276d3b](3276d3b)) * **dhparams:** allow generating Diffie Hellman parameters on Windows ([3802024](3802024)) * **fedora:** honor working directory & service name ([4f8e899](4f8e899)) * **freebsd:** load if_tap module ([d63581a](d63581a)) * **gitlab:** use Travis instances ([44f6bc1](44f6bc1)) * **ifconfig_pool_persist.sls:** fix `salt-lint` errors ([6969083](6969083)) * **jinja:** don't call pillar.get ([33b98f5](33b98f5)) * **logging:** set replace=False and add dependencies for log files ([9b71fcf](9b71fcf)) * **macros:** use openvpn/macros.jinja ([637387e](637387e)) * **map.jinja:** fix `salt-lint` errors ([eabfc57](eabfc57)) * **network_manager_networks:** properly override port ([1d58ec6](1d58ec6)) * **network_manager_networks:** reduced pillar.get calls ([7ee9eed](7ee9eed)) * **release.config.js:** use full commit hash in commit link [skip ci] ([81d922d](81d922d)) * **repo:** provide EPEL repo configuration for `Amazon Linux-2` ([bfb29bd](bfb29bd)) * **service:** make sure the now obsolete systemd services are disabled ([2dfae46](2dfae46)) * **service:** removed trailing whitespace ([85d2458](85d2458)) * **service:** stop old service only if name is different to new service ([1724dfd](1724dfd)), closes [saltstack-formulas#119](https://github.com/myii/openvpn-formula/issues/119) * **service:** use OS-specific service name in multi-service setups ([b16756c](b16756c)) * **specs:** use boolean operator ([89fa956](89fa956)) * **tap-adapter.ps1:** work with alternate name `Local Area Connection` ([372b3b6](372b3b6)) * **test:** drop ' then$' ([62c2f70](62c2f70)) * **test:** dropped redundant permission checks ([9c3ea71](9c3ea71)) ### Continuous Integration * **cleanup:** dropped obsolete opensuse-leap-15 workaround ([1e1719d](1e1719d)) * **gemfile:** restrict `train` gem version until upstream fix [skip ci] ([ed6b7f0](ed6b7f0)) * **gemfile.lock:** add to repo with updated `Gemfile` [skip ci] ([0aa9fd6](0aa9fd6)) * **github:** add Windows testing using Actions ([2d4b79c](2d4b79c)) * **gitlab:** test `semantic-release` back to GitHub ([0ead7f1](0ead7f1)) * **gitlab:** use GitLab CI as Travis CI replacement ([c9e4a8c](c9e4a8c)) * **kitchen:** add kitchen file + testinfra ([9c5ee26](9c5ee26)) * **kitchen:** avoid using bootstrap for `master` instances [skip ci] ([6eb1b44](6eb1b44)) * **kitchen:** change `log_level` to `debug` instead of `info` ([e94c9ba](e94c9ba)) * **kitchen:** install required packages to bootstrapped `opensuse` [skip ci] ([b76dcc9](b76dcc9)) * **kitchen:** rename pillar ([4122fc0](4122fc0)) * **kitchen:** test/config/pillars: add jinja for user on debian >= 9 ([3c7f947](3c7f947)) * **kitchen:** use `debian-10-master-py3` instead of `develop` [skip ci] ([83e00e1](83e00e1)) * **kitchen:** use `develop` image until `master` is ready (`amazonlinux`) [skip ci] ([06a09f2](06a09f2)) * **kitchen:** use `saltimages` Docker Hub where available [skip ci] ([740ba4e](740ba4e)) * **kitchen:** use bootstrapped `opensuse` images until `2019.2.2` [skip ci] ([0db9651](0db9651)) * **kitchen+travis:** modify matrix to include `develop` platform ([91b5798](91b5798)) * **kitchen+travis:** remove `master-py2-arch-base-latest` [skip ci] ([9e7aa34](9e7aa34)) * **kitchen+travis:** replace EOL pre-salted images ([2577535](2577535)) * **kitchen+travis:** upgrade matrix after `2019.2.2` release [skip ci] ([4eb9d3b](4eb9d3b)) * **platform:** add `arch-base-latest` (commented out for now) [skip ci] ([75d7aaa](75d7aaa)) * **pre-commit:** add to formula [skip ci] ([95bbd5e](95bbd5e)) * **pre-commit:** enable/disable `rstcheck` as relevant [skip ci] ([92e02f2](92e02f2)) * **pre-commit:** finalise `rstcheck` configuration [skip ci] ([44e040d](44e040d)) * avoid `init_environment` failing due to saltstack/salt[#57628](https://github.com/myii/openvpn-formula/issues/57628) ([398932b](398932b)) * **specs:** increased readability ([b2c9cf1](b2c9cf1)) * **test data:** moved Pillar test data ([2fff1ee](2fff1ee)) * **testing:** added bin/kitchen ([15bea7b](15bea7b)) * **travis:** add notifications => zulip [skip ci] ([80930cd](80930cd)) * **travis:** apply changes from build config validation [skip ci] ([ea3336a](ea3336a)) * **travis:** exclude Fedora 29 from Travis CI ([4a1f9ed](4a1f9ed)) * **travis:** merge `rubocop` linter into main `lint` job ([9f82955](9f82955)) * **travis:** opt-in to `dpl v2` to complete build config validation [skip ci] ([bb43f31](bb43f31)) * **travis:** quote pathspecs used with `git ls-files` [skip ci] ([667bc1f](667bc1f)) * **travis:** run `shellcheck` during lint job [skip ci] ([9d63e36](9d63e36)) * **travis:** test based on template-formula and [saltstack-formulas#98](https://github.com/myii/openvpn-formula/issues/98) ([b9daf9b](b9daf9b)) * **travis:** update `salt-lint` config for `v0.0.10` [skip ci] ([d465b4f](d465b4f)) * **travis:** use `major.minor` for `semantic-release` version [skip ci] ([4099f15](4099f15)) * **travis:** use build config validation (beta) [skip ci] ([d2f7fe2](d2f7fe2)) * **workflows/commitlint:** add to repo [skip ci] ([5900915](5900915)) * merge travis matrix, add `salt-lint` & `rubocop` to `lint` job ([d7f1607](d7f1607)) * merge travis matrix, add `salt-lint` & `rubocop` to `lint` job ([70dab6c](70dab6c)) * **yamllint:** add rule `empty-values` & use new `yaml-files` setting ([a437b3b](a437b3b)) * use `dist: bionic` & apply `opensuse-leap-15` SCP error workaround ([5e02797](5e02797)) ### Documentation * add steps required for testing using Vagrant ([0229d14](0229d14)) * **contributing:** remove to use org-level file instead [skip ci] ([8703eb5](8703eb5)) * **pillar.example:** update with quoted "yes" for comp-lzo ([1b49b24](1b49b24)) * **readme:** update link to `CONTRIBUTING` [skip ci] ([a72049f](a72049f)) ### Features * **auth_gen_token:** support for auth-gen-token ([333edd7](333edd7)) * **auth_nocache:** support for auth-nocache ([c21b7f5](c21b7f5)) * **syslog:** support for syslog ([24b370c](24b370c)) * **yamllint:** include for this repo and apply rules throughout ([4355ac6](4355ac6)) ### Performance Improvements * **travis:** improve `salt-lint` invocation [skip ci] ([26838e5](26838e5)) ### Tests * **map:** verify `map.jinja` dump using `_mapdata` state ([ecac1b1](ecac1b1)) * add test for auth-nocache option ([79c1055](79c1055)) * **kitchen:** debian and ubuntu use different paths now ([dfd784e](dfd784e)) * **pillar:** set 'status' to fix kitchen tests ([07bb5b6](07bb5b6)) * **windows:** add local testing of Windows using Vagrant/Virtualbox ([96c3001](96c3001))

myii added a commit to myii/ssf-formula that referenced this issue Sep 19, 2019

feat(openvpn): fix EPEL repo configuration for Amazon Linux-2

2baba20

* saltstack-formulas/openvpn-formula#119

This was referenced Sep 19, 2019

feat(openvpn): fix EPEL repo configuration for Amazon Linux-2 myii/ssf-formula#38

Merged

fix(repo): provide EPEL repo configuration for Amazon Linux-2 #122

Merged

myii added a commit to myii/openvpn-formula that referenced this issue Sep 20, 2019

fix(service): stop old service only if name is different to new service

62fc957

* Fix saltstack-formulas#119

myii added a commit to myii/openvpn-formula that referenced this issue Sep 20, 2019

fix(service): stop old service only if name is different to new service

be7dd34

* Fix saltstack-formulas#119

myii mentioned this issue Sep 20, 2019

docs(issues): provide Bug report & Feature request templates saltstack-formulas/template-formula#171

Merged

myii added a commit to myii/ssf-formula that referenced this issue Sep 21, 2019

feat(openvpn): fix EPEL repo configuration for Amazon Linux-2

0702630

* saltstack-formulas/openvpn-formula#119

myii added a commit to myii/openvpn-formula that referenced this issue Sep 21, 2019

fix(service): stop old service only if name is different to new service

28ffe68

* Fix saltstack-formulas#119

myii added a commit to myii/openvpn-formula that referenced this issue Sep 21, 2019

fix(service): stop old service only if name is different to new service

6beb6d7

* Fix saltstack-formulas#119

myii mentioned this issue Sep 21, 2019

fix(service): stop old service only if name is different to new service #123

Merged

myii added a commit to myii/openvpn-formula that referenced this issue Sep 21, 2019

ci(kitchen): get debug logs before fix for saltstack-formulas#119

2e1ab33

myii added a commit to myii/openvpn-formula that referenced this issue Sep 21, 2019

ci(kitchen): get debug logs after fix for saltstack-formulas#119

c9b41a7

alxwr closed this as completed in #123 Sep 25, 2019

alxwr pushed a commit that referenced this issue Sep 25, 2019

fix(service): stop old service only if name is different to new service

1724dfd

* Fix #119

saltstack-formulas-travis added the released label Sep 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tunnels are restarted every time highstate runs #119

tunnels are restarted every time highstate runs #119

cmclaughlin commented Sep 7, 2019

cmclaughlin commented Sep 9, 2019

n-rodriguez commented Sep 9, 2019

cmclaughlin commented Sep 9, 2019

myii commented Sep 9, 2019 •

edited

Loading

cmclaughlin commented Sep 9, 2019

myii commented Sep 9, 2019

cmclaughlin commented Sep 9, 2019

myii commented Sep 9, 2019

myii commented Sep 10, 2019

daks commented Sep 11, 2019

myii commented Sep 11, 2019

n-rodriguez commented Sep 11, 2019 •

edited

Loading

myii commented Sep 11, 2019

n-rodriguez commented Sep 11, 2019 •

edited

Loading

n-rodriguez commented Sep 11, 2019

myii commented Sep 12, 2019

myii commented Sep 12, 2019

daks commented Sep 12, 2019

myii commented Sep 12, 2019

myii commented Sep 13, 2019

daks commented Sep 14, 2019 •

edited

Loading

myii commented Sep 14, 2019 •

edited

Loading

n-rodriguez commented Sep 14, 2019

myii commented Sep 16, 2019 •

edited

Loading

daks commented Sep 16, 2019

myii commented Sep 19, 2019

myii commented Sep 19, 2019

cmclaughlin commented Sep 19, 2019

myii commented Sep 20, 2019

cmclaughlin commented Sep 21, 2019

myii commented Sep 21, 2019

saltstack-formulas-travis commented Sep 25, 2019

tunnels are restarted every time highstate runs #119

tunnels are restarted every time highstate runs #119

Comments

cmclaughlin commented Sep 7, 2019

cmclaughlin commented Sep 9, 2019

n-rodriguez commented Sep 9, 2019

cmclaughlin commented Sep 9, 2019

myii commented Sep 9, 2019 • edited Loading

cmclaughlin commented Sep 9, 2019

myii commented Sep 9, 2019

cmclaughlin commented Sep 9, 2019

myii commented Sep 9, 2019

myii commented Sep 10, 2019

daks commented Sep 11, 2019

myii commented Sep 11, 2019

n-rodriguez commented Sep 11, 2019 • edited Loading

myii commented Sep 11, 2019

n-rodriguez commented Sep 11, 2019 • edited Loading

n-rodriguez commented Sep 11, 2019

myii commented Sep 12, 2019

myii commented Sep 12, 2019

daks commented Sep 12, 2019

myii commented Sep 12, 2019

myii commented Sep 13, 2019

daks commented Sep 14, 2019 • edited Loading

myii commented Sep 14, 2019 • edited Loading

n-rodriguez commented Sep 14, 2019

myii commented Sep 16, 2019 • edited Loading

daks commented Sep 16, 2019

myii commented Sep 19, 2019

myii commented Sep 19, 2019

cmclaughlin commented Sep 19, 2019

myii commented Sep 20, 2019

cmclaughlin commented Sep 21, 2019

myii commented Sep 21, 2019

saltstack-formulas-travis commented Sep 25, 2019

myii commented Sep 9, 2019 •

edited

Loading

n-rodriguez commented Sep 11, 2019 •

edited

Loading

n-rodriguez commented Sep 11, 2019 •

edited

Loading

daks commented Sep 14, 2019 •

edited

Loading

myii commented Sep 14, 2019 •

edited

Loading

myii commented Sep 16, 2019 •

edited

Loading