-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix imports using tplroot #77
base: master
Are you sure you want to change the base?
Conversation
Thanks for your contribution, @fgionghi. Now this is interesting, because we only just moved away from I must note that we've got Windows testing set up for this formula and it has been working well for some time now (https://github.com/saltstack-formulas/packages-formula/actions). That is specifically checking the Lines 806 to 817 in b5b400f
This is the test pillar being used there: packages-formula/test/salt/pillar/windows.sls Lines 4 to 19 in b5b400f
In order to get to the bottom of this, it would be helpful if you can provide details about your environment, so that we can attempt to reproduce the error. Filling out the bug report template would be useful. |
Ok, I submitted an issue: #79. |
PR progress checklist (to be filled in by reviewers)
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Describe the changes you're proposing
The problem was that salt-minion didn't cache all the files used by the formula on windows clients.
In fact when I applied the
packages.chocolatey
state only thechocolatey.sls
file was found on the cache folder.This triggered an error because salt couldn't find the
map.jinja
file.Importing files using
tplroot
instead of using relative path seems to fix the problem.