feat(semantic-release): implement an automated changelog #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myii
requested changes
May 29, 2019
There was a problem hiding this comment.
Another milestone PR, great work! A few changes inline and a few more suggestion here:
- Still needs:
bin/kitchentest/integration/default/inspec.yml
- Directory structure (standard locations):
test/integration/default/pkgs_spec.rb=>test/integration/default/controls/pkgs_spec.rbtest/integration/default/service_spec.rb=>test/integration/default/controls/service_spec.rb
docs/README.rst
Outdated
| ``bin/kitchen converge`` | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| Creates the docker instance and runs the main(s) state(s), ready for testing. |
There was a problem hiding this comment.
I usually check kitchen.yml to see which states are being run. But something like this could be a better solution in the long-term, by fixing it in the template-formula. Not really main(s) state(s), though. Perhaps main state(s) is good enough.
There was a problem hiding this comment.
yes, main state(s) is more correct
71 tasks
|
changes asked pushed. |
|
Excellent, thanks @daks -- merged. |
|
🎉 This PR is included in version 0.17.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP based on previous work. May need updates.
Very basic tests (same as before) but they pass on all platforms! :) https://travis-ci.com/daks/postfix-formula/builds/113663324