Using pillar.example as template difficulties

[noelmcloughlin]

A few weeks back I tested installation of this formula on Fedora/Debian/OpenSUSE without pillars and this worked good. Repeating this test "with pillars" using pillar.example as template was unsuccessful as many individual states failed. I solved by including following in pillar.example.

postgres:
use_upstream_repo: False
version: '9.6'
{% if salt'grains.get' == 'RedHat' or salt'grains.get' == 'SUSE' %}
pkgs_extra: [ postgresql-contrib, postgresql-plpython, postgresql-jdbc, postgresql-docs]
{% elif salt'grains.get' == 'Debian' %}
pkg: postgresql-9.6
pkgs_extra: [ postgresql-contrib, postgresql-plpython-9.6, libpostgresql-jdbc-java]
python: python-psycopg2
conf_dir: /var/lib/postgresql/data
postgresconf: ""
{% endif %}

prepare_cluster:
{% if salt'grains.get' == 'RedHat' %}
command: /usr/bin/initdb --pgdata=/var/lib/pgsql/data
test: test -f /var/lib/pgsql/data/PG_VERSION
{% elif salt'grains.get' == 'SUSE' %}
command: /usr/lib/postgresql/9.6/bin/initdb --pgdata=/var/lib/pgsql/data
test: test -f /var/lib/pgsql/data/PG_VERSION
{% elif salt'grains.get' == 'Debian' %}
command: /usr/lib/postgresql/9.6/bin/initdb --pgdata=/var/lib/postgresql/data
test: test -f /var/lib/postgresql/data/PG_VERSION
{% endif %}
user: postgres
env: {}

Should I raise PR to update pillar.example with same (perhaps commented out) as workaround to help others?

[EvaSDK]

Do I understand correctly that you just copied pillar.example into your pillars ? If so, this will not work for sure as it is only meant to show what can be configured, not to provide a working configuration.

[noelmcloughlin]

Yes I understand its a template. However I could update pillar.example showing this example working pillars - because it took me quite a while to nail this. This section would be commented out.

So my question is whether you think this is worthwhile, if yes I'll do PR. Thanks @EvaSDK

[EvaSDK]

Making the whole pillar.example be compatible with all supported distros does seem like an extensive maintenance work so I'd wouldn't recommend doing it, but I'm not the formula's maintainer :).

[noelmcloughlin]

I was thinking we add the support above but "commented out" ;-)

[noelmcloughlin]

@EvaSDK please review PR - I updated osmap.yaml instead.