Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SUSE packages #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tacerus
Copy link

@tacerus tacerus commented Feb 15, 2023

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Add support for openSUSE Leap and SUSE Linux Enterprise.

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

  • add correct package names and configuration file paths to map
  • add logic to prevent formula from changing users and groups managed by system packages

Pillar / config required to test the proposed changes

prometheus:
  wanted:
    component:
      - prometheus
      - alertmanager
      - node_exporter
      - blackbox_exporter
      - hacluster_exporter
      - postgres_exporter
      - saptune_exporter
      - webhook_snmp
  exporters:
    node_exporter:
      textfile_collectors:
        ipmitool:
          enable: true

  pkg:
    component:
      alertmanager:
        config:
          global:
            smtp_smarthost: foo:465
      node_exporter:
        environ:
          args:
            web.listen-address: ':9220'
      prometheus:
        environ:
          args:
            web.listen-address: ':9330'
        config:
          global:
            scrape_interval: 30s
      webhook_snmp:
        environ:
          args:
            snmp-port: ':1234'
      hacluster_exporter:
        environ:
          args:
            web.listen-address: ':9330'
      postgres_exporter:
        environ:
          args:
            web.listen-address: ':9330'

Debug log showing how the proposed changes work

GitHub blocks me from adding such long output. You can find it for three months on https://paste.opensuse.org/pastes/4007f64cfce4.

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

Used the opportunity to remove the trailing %} characters from the environment file template.

@tacerus tacerus force-pushed the suse branch 7 times, most recently from 57863d6 to 2d5e549 Compare February 15, 2023 02:46
@tacerus
Copy link
Author

tacerus commented Feb 15, 2023

How/where should I define a separate Inspec profile containing the packaged file permissions ?

- add all components available in the default openSUSE Leap (OSS)
  repository to osfamilymap
- introduce global manage_user_group toggle to prevent the formula from
  changing users and groups managed by system packages
- allow configuration file override using
  pkg:component:<component>:config_file

Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
Remove useless "%}" from comment in file.

Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant